-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick sequential core proposals and create-dapp #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
changed the title
Mhofman/some upgrade 14 cherry pick
Cherry-pick sequential core proposals and create-dapp
Jan 30, 2024
feat(cosmos): contextual and declarative VM action field defaults
mhofman
force-pushed
the
mhofman/some-upgrade-14-cherry-pick
branch
from
January 30, 2024 18:24
31665db
to
4b0644c
Compare
Merged
mhofman
commented
Jan 30, 2024
feat(extract-proposal): organize proposals into steps
feat(create-dapp): `npm create @agoric/dapp ...` uses `agoric init`
feat: pull `create-dapp`, `xsnap`, and `agoric-cli` changes from release-getting-started branch
* use dapp-game-pieces (in agoric-labs) by default * feat: use dapp-offer-up in @agoric/dapp * fix(integration-test): update initOptions with '--dapp-template' parameter * fix(integration-test): set --dapp-template at registry.sh level * Revert "fix(integration-test): update initOptions with '--dapp-template' parameter" This reverts commit 2097951. * Revert "fix(integration-test): set --dapp-template at registry.sh level" This reverts commit 8ec4ed3. * fix(integration-test): add --dapp-template parameter to myMain command * fixup! fix(integration-test): add --dapp-template parameter to myMain command --------- Co-authored-by: Luqi Pan <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
force-pushed
the
mhofman/some-upgrade-14-cherry-pick
branch
from
January 30, 2024 23:27
4b0644c
to
b350c41
Compare
gibson042
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inclusions look reasonable, and I was able to reproduce the branch state with the documented git rebase todo. 👍
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #8747 and #8743, cherry-picking some more recent changes from the master branch slated for inclusion in the upgrade-14 release. In particular:
create-dapp
package with new dapp defaultnpm create @agoric/dapp ...
usesagoric init
#8530create-dapp
,xsnap
, andagoric-cli
changes from release-getting-started branch #8799dev-
branches as supported PR target #8828Constructed using the following rebase-todo:
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
The documentation for Getting started will be updated after release
Testing Considerations
Existing CI, plus upcoming manual testing of combined wallet factory and zoe upgrades in a single chain software upgrade
Upgrade Considerations
In support of upgrade-14