ci(restore-node): detect staged yarn.lock, package.json #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-staged-endo
branch
from
cea5cb9
to
70cb214
Compare
mhofman
approved these changes
Aug 9, 2023
Comment on lines
+136
to
+137
| # (First column is non-space, second column is space, followed by separator.) | ||
| if [ -n "$(git status --porcelain | grep -Eve '^[^ ] '; true)" ]; then |
There was a problem hiding this comment.
I think '^M ' would work too, right?
There was a problem hiding this comment.
Yes, that should work too. Would you prefer it?
There was a problem hiding this comment.
It'd be a little clearer, but I don't care enough to request a change
mhofman
pushed a commit
that referenced
this pull request
Aug 15, 2023
ci(restore-node): detect staged yarn.lock, package.json
mhofman
pushed a commit
that referenced
this pull request
Aug 15, 2023
ci(restore-node): detect staged yarn.lock, package.json
mhofman
pushed a commit
that referenced
this pull request
Jan 12, 2024
ci(restore-node): detect staged yarn.lock, package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#not-endo-branch: master
refs: #8155
Description
I didn't correctly test #8155 against an Endo branch, so it failed during the nightly scheduled job. Let's try again:
yarn.lockandpackage.jsonwhen setting#endo-branch: XXXnotify-statusaction from the correct path fortest-dapp-*.ymlSecurity Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Tested CI against Endo master, with one expected failure due to typing changes in the new Endo.
Upgrade Considerations
n/a