always init Endo in tests #8205
Conversation
There was a problem hiding this comment.
Hooray for less ceremony in writing tests! Is there a package.json template somewhere that should be updated as well?
It also looks like this pulls the rug out from under some dapp testing ("ReferenceError: HandledPromise is not defined"), but I trust that can be addressed. At a glance, it seems like test-….js files in dapp-card-store contract/test/ and dapp-otc contract/test/ and documentation snippets/ expect an import of @agoric/zoe/tools/prepare-test-env.js (in the case of Agoric/documentation, via its own prepare-test-env-ava.js) to initialize a Hardened JS environment (and probably a vat-like one) via @agoric/zoe/tools/prepare-test-env.js importing @agoric/swingset-liveslots/tools/prepare-test-env.js, which this PR updates to no longer import @agoric/internal/src/install-ses-debug.js and thereby breaks the expectation.
| @@ -1,5 +1,4 @@ | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
| // eslint-disable-next-line import/no-extraneous-dependencies |
| @@ -1,6 +1,5 @@ | |||
| /* eslint-disable ava/assertion-arguments -- the standard diff is unreadable */ | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
| // eslint-disable-next-line import/no-extraneous-dependencies |
| @@ -1,5 +1,4 @@ | |||
| // Must be first to set up globals | |||
There was a problem hiding this comment.
| // Must be first to set up globals |
| @@ -1,5 +1,4 @@ | |||
| // Must be first to set up globals | |||
| import '@endo/init/debug.js'; | |||
| // Consider ses-ava once https://github.com/endojs/endo/issues/1235 is resolved | |||
There was a problem hiding this comment.
endojs/endo#1235 is resolved, but many test files are now fine with just import test from 'ava' so I think we can drop this comment.
| // Consider ses-ava once https://github.com/endojs/endo/issues/1235 is resolved |
except agoric-cli and casting which have to shim 'fetch'
done by the prepare-test-env-ava import
refs: #2663
Description
Our test env setup has someproblems:
testmethods don't work endojs/endo#647)This PR tackles #2, and progress towards the others. It configures some aspects of test env preparation to be package-scoped instead of file scoped. It does this by configuring the Ava runner to import the modules that have the desired side-effects. In this case,
@endo/init/debug.js.Many tests were using only that and then
import ava from 'ava'instead ofprepare-test-env-ava. This frees those tests of any side-effect imports.With this pattern maybe we could also make a
@endo/ses-ava/monkeypatchthat modifies the the Ava module instead of wrapping. If we can do that in a way that's fully compatible with Ava then we could always run that patch and remove another test-level concern. Most tests at that point could just begin withimport test from 'ava'.The other setup tasks are adding
reincarnateand/orVatData. I expect those are needed on a package basis and could have the same package-level config.Security Considerations
--
Scaling Considerations
--
Documentation Considerations
Will require notifying developers when this lands that the old imports are redundant.
Testing Considerations
CI
Upgrade Considerations
--