Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: schedule nightly test against Endo master #7887

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

michaelfig
Copy link
Member

Description

First cut at running a nightly (it is night somewhere) Endo master branch integration test. I wrote this based on Github documentation, so I'm not entirely sure if it will work well, but unfortunately we need to merge it to Agoric SDK master before we can see the results.

Security Considerations

Exercises grabbing code from Endo more frequently, but we already did that when synchronising the repositories, so it probably isn't more of a risk.

Scaling Considerations

Documentation Considerations

Testing Considerations

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to merge this see if it works

Comment on lines +16 to +17
schedule:
- cron: '17 6 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I yanked all the logic related to mergify and not running tests unless conditions are met, this is fine for now, but whoever backs out those changes to re-enable mergify will need to make that logic compatible with schedule triggers (likely as simple as verifying the same conditions as push to named branches are met).

@michaelfig michaelfig added this pull request to the merge queue Jun 6, 2023
Merged via the queue into master with commit 2043349 Jun 6, 2023
@michaelfig michaelfig deleted the mfig-periodic-endo branch June 6, 2023 17:12
mhofman pushed a commit that referenced this pull request Aug 7, 2023
ci: schedule nightly test against Endo master
mhofman pushed a commit that referenced this pull request Jan 12, 2024
ci: schedule nightly test against Endo master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants