Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deployment): only install ansible and terraform if not available #8169

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Aug 9, 2023

Description

Only install ansible, terraform and other deps in the deployment integration test if not already installed. It won't have any effect in CI because those are not available, but will save me about 3-4 minutes and bandwidth every time I need to run this test locally. I'm updating the dev env docker image to include those dependencies.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Checked locally on my debian image. May work too on Darwin

Upgrade Considerations

None

@mhofman mhofman added the tooling repo-wide infrastructure label Aug 9, 2023
@mhofman mhofman requested a review from michaelfig August 9, 2023 18:58
@mhofman mhofman force-pushed the mhofman/dont-reinstall-deployment-test-deps branch from b1b22db to 8b617e1 Compare August 9, 2023 20:14
@mhofman mhofman enabled auto-merge August 9, 2023 20:59
@mhofman mhofman added this pull request to the merge queue Aug 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 9, 2023
@mhofman mhofman added this pull request to the merge queue Aug 19, 2023
@mhofman mhofman removed this pull request from the merge queue due to a manual request Aug 19, 2023
@mhofman mhofman force-pushed the mhofman/dont-reinstall-deployment-test-deps branch from 8b617e1 to e68b29d Compare August 19, 2023 13:25
@mhofman mhofman enabled auto-merge August 19, 2023 13:25
@mhofman mhofman added this pull request to the merge queue Aug 19, 2023
Merged via the queue into master with commit 4b52dd6 Aug 19, 2023
65 of 67 checks passed
@mhofman mhofman deleted the mhofman/dont-reinstall-deployment-test-deps branch August 19, 2023 14:14
mhofman added a commit that referenced this pull request Jan 12, 2024
…t-test-deps

ci(deployment): only install ansible and terraform if not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants