Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.11.13 #1431

Merged
merged 40 commits into from
Feb 20, 2021
Merged

Release 0.11.13 #1431

merged 40 commits into from
Feb 20, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 19, 2021

Breaking changes:

Features:

Updated dependencies:

Fixes:

Other:

lcontento and others added 30 commits January 28, 2021 20:44
Adapt to changed error message. Closes #1385.
* Use PEP 517 pyproject.toml (taking proper care of dependencies of setup.py itself)
* Use setup.cfg
* NOTE: creating a source distribution now requires https://github.com/pypa/build (or manual installation of the build requirements)
Allows specifying e.g. `-fno-openmp` via AMICI_CXXFLAGS
Fixes CMake deprecation warning
Petablint previously failed if observableFormula or noiseFormula contained pysb observables or expressions
* Upgrade to sundials 5.7.0

* Disable shared libs

* No __attribute__ ((__deprecated__)) for msvc

* Revert "No __attribute__ ((__deprecated__)) for msvc"

This reverts commit 8dfac2b.

* No __attribute__ ((__deprecated__)) for msvc

* Fix error C2059: syntax error: 'constant'?

* DBG

* d'oh

* ..

* SUNDIALS_DEPRECATED

* SUNDIALS_DEPRECATED for __GNUC__

* update error code for singular jacobian and add static assert

Co-authored-by: Fabian Fröhlich <[email protected]>
Co-authored-by: FFroehlich <[email protected]>
* Extract ModelDimensions from Model

update code generation and templates

* Regenerate test models

* update tests

* Update serialization

* Extract ModelDimensions from ReturnData

* Update operator==

* Swig: order matters

* const&

* static cast const&
Missed updating this one in d7392e2
* account for heaviside functions in expressions

* fix adjoint events if event coincides with datapoint

* fixup

* fix cassert

* enable starting in an event

* change assert to exception

* fixup adjoint

* fixup heaviside implementation

* fix xdot backsubstitutions

* reinit heaviside after pre-simulation/equilibration

* fix heaviside initialization

* add documentation, fix cpp Heaviside implementation

* disable Chen because that model is just awesome

* update unittest
* Refactor Model: Extract ModelStateDerived

* Remove unused my_ and mz_

* Use swig 4.0.2 for docs
…initial value (#1397)

* unspecified initial states in PEtab conditions table default to SBML initial value

* review, fix f-string

* review

* review

Co-authored-by: Fabian Fröhlich <[email protected]>
Co-authored-by: Daniel Weindl <[email protected]>
Should prevent errors like

```
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
[...]
ImportError: numpy.core.multiarray failed to import
```
…1407)

This allows using Model without ExpData unless there really are measurements. Also avoids having to add any new member of ExpData also to Model and slims down Model a bit. Getters and setters for SimulationParameters members are still in Model, which is to preserve backwards compatibility for ExpData, which allowed unchecked access to the respective members. Further refactoring to follow.

Partially addresses #931 (moving ID / name functions is still missing).
In some places it was already written that we require python>=3.7.
This removes any Python3.6 leftovers.
(previously, only README.md was updated)
as the GitHub action workers don't have too much disk space and those files should be removed anyways.
... because thousands of line per file are a pain
* CI: Allow tests on unstable python version to fail

* Disable 3.10.0-alpha.5 for now
* Doc: Add table with AMICI C++/Python/Matlab feature comparison
* Link and update details on SBML support

Co-authored-by: Fabian Fröhlich <[email protected]>
fixes #1217

* slim model/abstract model

* ignore context managers

* add ignores for solver

* try again to get rid of context managers

* fixup?

* fixup

* add more model ignores

* Update swig/amici.i

Co-authored-by: Daniel Weindl <[email protected]>

Co-authored-by: Daniel Weindl <[email protected]>
fixes #1421

* test

* test

* test

* fix

* fixup

* fixup?

* try autolink?

* fixup?

* fixup?

* fix fixup
Fabian Fröhlich and others added 8 commits February 17, 2021 22:34
fixes #1415

* fix notebook?

* fix notebook formatting?
Include supported tags (i.e. at least 1 passed test with the given tag) in sbml semantic test suite summary.
Description of the tags is available at https://github.com/sbmlteam/sbml-test-suite/blob/master/docs/tags-documentation/all-tags.txt
…fixes (#1417)

Adds possibility to provide state indices for selective reinitialization based on fixed parameters.

The previous `ExpData::reinitializeFixedParameterInitialStates` is still there, but will be removed in an upcoming version.


Addresses #1345, #1396, #1319

Supersedes #1344 

Include new test cases from PEtab-dev/petab_test_suite#35
* add pysb benchmarking script

* add file description

Co-authored-by: Daniel Weindl <[email protected]>
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1431 (f7311cf) into master (b113544) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   78.80%   79.02%   +0.22%     
==========================================
  Files          63       66       +3     
  Lines        9944    10099     +155     
==========================================
+ Hits         7836     7981     +145     
- Misses       2108     2118      +10     
Flag Coverage Δ
cpp 75.69% <ø> (+0.32%) ⬆️
petab 69.59% <ø> (+0.08%) ⬆️
python 67.61% <ø> (-0.49%) ⬇️
sbmlsuite 90.88% <ø> (+2.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/exception.cpp 82.60% <0.00%> (-8.70%) ⬇️
src/spline.cpp 65.26% <0.00%> (-6.32%) ⬇️
ThirdParty/gsl/gsl/gsl-lite.hpp 91.89% <0.00%> (-5.41%) ⬇️
src/backwardproblem.cpp 63.73% <0.00%> (-1.04%) ⬇️
src/forwardproblem.cpp 90.53% <0.00%> (-0.99%) ⬇️
src/model_dae.cpp 47.51% <0.00%> (-0.66%) ⬇️
src/sundials_matrix_wrapper.cpp 83.61% <0.00%> (-0.43%) ⬇️
src/edata.cpp 88.01% <0.00%> (-0.23%) ⬇️
src/solver_cvodes.cpp 70.20% <0.00%> (-0.21%) ⬇️
src/rdata.cpp 94.72% <0.00%> (-0.21%) ⬇️
... and 18 more

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2021

@dweindl dweindl merged commit b090fbb into master Feb 20, 2021
@dweindl dweindl deleted the release_0.11.13 branch February 20, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants