Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Model: Extract ModelStateDerived #1399

Merged
merged 9 commits into from
Feb 2, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 1, 2021

... to slim down amici::Model

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1399 (936da87) into develop (8f7ef5c) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1399      +/-   ##
===========================================
- Coverage    76.61%   76.28%   -0.33%     
===========================================
  Files           22       22              
  Lines         3181     3799     +618     
===========================================
+ Hits          2437     2898     +461     
- Misses         744      901     +157     
Flag Coverage Δ
petab 69.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 86.43% <0.00%> (-5.87%) ⬇️
python/amici/sbml_import.py 89.12% <0.00%> (-4.45%) ⬇️

@dweindl dweindl merged commit 8c7aada into develop Feb 2, 2021
@dweindl dweindl deleted the refactor_model_state branch February 2, 2021 12:07
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants