Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timepoint out of bounds access #1402

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix timepoint out of bounds access #1402

merged 1 commit into from
Feb 3, 2021

Conversation

FFroehlich
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1402 (9d74446) into develop (19d3a06) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1402      +/-   ##
===========================================
+ Coverage    78.66%   78.74%   +0.07%     
===========================================
  Files           63       63              
  Lines        10008    10008              
===========================================
+ Hits          7873     7881       +8     
+ Misses        2135     2127       -8     
Flag Coverage Δ
cpp 75.28% <100.00%> (+0.11%) ⬆️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/backwardproblem.cpp 63.73% <100.00%> (ø)
src/sundials_matrix_wrapper.cpp 84.25% <0.00%> (+0.42%) ⬆️
src/spline.cpp 71.57% <0.00%> (+6.31%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit afcb2e2 into develop Feb 3, 2021
@FFroehlich FFroehlich deleted the fix_adjoint branch February 3, 2021 19:31
@dweindl dweindl mentioned this pull request Feb 19, 2021
dweindl added a commit that referenced this pull request Feb 20, 2021
….13)

Breaking changes:
* AMICI requires Python>=3.7
* Updated package installation (PEP517/518): 
  Creating source distributions requires https://github.com/pypa/build (#1384)
  (but now handles all package building dependencies properly)

Features:
* More flexible state reinitialization (#1417)

Updated dependencies:
* Upgrade to sundials 5.7.0 (#1392)

Fixes:
* Python: account for heaviside functions in expressions (#1382)
* Python: allow loading of existing models in import_petab_problem (#1383)
* Python: Don't override user-provided compiler/linker flags (#1389)
* Python: PEtab import reinitialization fixes (#1417)
* Python: Fix PEtab observables for pysb models (#1390)
* Python: Substitute expressions in event condition expressions (#1404)
* Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397)
* C++: Fix timepoint out of bounds access (#1402)
* C++: Fix exported CMake config (#1388)
* Fixed Dockerfile: add python3-venv (#1398, #1408)

Other:
* Slim exported swig interface (#1425)
* Updated documentation
    * Getting started tutorial (#1423)
    * List supported SBML test tags (#1428)
    * Add AMICI C++/Python/Matlab feature comparison (#1409)
    * ...
* Various minor CI improvements
* ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants