Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1415 #1426

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Fix 1415 #1426

merged 3 commits into from
Feb 18, 2021

Conversation

FFroehlich
Copy link
Member

fixes #1415

@FFroehlich FFroehlich changed the base branch from master to develop February 17, 2021 21:48
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1426 (407d720) into develop (0aa27b6) will increase coverage by 2.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1426      +/-   ##
===========================================
+ Coverage    76.57%   78.81%   +2.24%     
===========================================
  Files           22       66      +44     
  Lines         3185    10061    +6876     
===========================================
+ Hits          2439     7930    +5491     
- Misses         746     2131    +1385     
Flag Coverage Δ
cpp 75.42% <ø> (?)
petab 69.48% <ø> (ø)
python 67.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/symbolic_functions.cpp 74.84% <0.00%> (ø)
src/abstract_model.cpp 3.09% <0.00%> (ø)
src/solver_idas.cpp 36.57% <0.00%> (ø)
src/model_dae.cpp 47.51% <0.00%> (ø)
src/cblas.cpp 100.00% <0.00%> (ø)
include/amici/misc.h 80.00% <0.00%> (ø)
src/misc.cpp 67.01% <0.00%> (ø)
src/exception.cpp 82.60% <0.00%> (ø)
include/amici/vector.h 87.50% <0.00%> (ø)
src/newton_solver.cpp 78.91% <0.00%> (ø)
... and 45 more

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich merged commit e93b43b into develop Feb 18, 2021
@FFroehlich FFroehlich deleted the fix_1415 branch February 18, 2021 03:34
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini: Notebook not formatted correctly
3 participants