Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: SBML test suite: show tag summary for passed tests #1420

Merged
merged 9 commits into from
Feb 18, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 16, 2021

Include supported tags (i.e. at least 1 passed test with the given tag) in sbml semantic test suite summary.
Description of the tags is available at https://github.com/sbmlteam/sbml-test-suite/blob/master/docs/tags-documentation/all-tags.txt

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1420 (e2d8e8c) into develop (24f563a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1420      +/-   ##
===========================================
- Coverage    79.06%   79.03%   -0.03%     
===========================================
  Files           66       66              
  Lines        10061    10061              
===========================================
- Hits          7955     7952       -3     
- Misses        2106     2109       +3     
Flag Coverage Δ
cpp 75.74% <ø> (-0.05%) ⬇️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)
sbmlsuite 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/amici.cpp 74.31% <0.00%> (-5.51%) ⬇️
src/exception.cpp 82.60% <0.00%> (ø)
src/solver_cvodes.cpp 70.20% <0.00%> (ø)
src/sundials_matrix_wrapper.cpp 84.04% <0.00%> (+0.63%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2021

@FFroehlich
Copy link
Member

FFroehlich commented Feb 17, 2021

Pretty sure we do not support DelayInEventAssignment and others, there still is something fishy with the analysis.

@dweindl
Copy link
Member Author

dweindl commented Feb 17, 2021

Pretty sure we do not support DelayInEventAssignment and others, there still is something fishy with the analysis.

I'd agree :D

Should be fixed now.

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

@dweindl dweindl merged commit 7621bec into develop Feb 18, 2021
@dweindl dweindl deleted the test_sbml_tags branch February 18, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants