Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] merge dev into main #660

Merged
merged 32 commits into from
Mar 1, 2024
Merged

[Merge] merge dev into main #660

merged 32 commits into from
Mar 1, 2024

Conversation

middlefitting
Copy link
Member

๐Ÿ“Œ ๊ฐœ์š”

  • flyway ํ…Œ์ด๋ธ” ๋ณ€๊ฒฝ ์ด์œ ๋กœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ด์ „์— merge๋ฅผ ์ˆ˜ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

Kimhan-nah and others added 30 commits January 20, 2024 19:20
Co-authored-by: yoahn <[email protected]>
Co-authored-by: wken5577 <[email protected]>
Co-authored-by: Hyunkyu Lee <[email protected]>
Co-authored-by: AYoungSn <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 72.51908% with 684 lines in your changes are missing coverage. Please review.

Project coverage is 74.12%. Comparing base (ed1d638) to head (da7fe73).
Report is 8 commits behind head on main.

Files Patch % Lines
...gpong/api/admin/user/service/UserAdminService.java 43.02% 47 Missing and 2 partials โš ๏ธ
...gg/pingpong/api/user/rank/service/RankService.java 42.50% 41 Missing and 5 partials โš ๏ธ
...ong/api/user/noti/service/sns/SlackbotService.java 2.32% 42 Missing โš ๏ธ
...min/tournament/service/TournamentAdminService.java 81.48% 15 Missing and 15 partials โš ๏ธ
...gg/pingpong/api/user/game/service/GameService.java 72.22% 15 Missing and 15 partials โš ๏ธ
...g/api/global/exception/GlobalExceptionHandler.java 40.00% 27 Missing โš ๏ธ
...ngpong/api/user/rank/redis/RedisUploadService.java 7.69% 24 Missing โš ๏ธ
...gpong/api/admin/game/service/GameAdminService.java 72.36% 11 Missing and 10 partials โš ๏ธ
...gg/pingpong/api/global/utils/UserImageHandler.java 20.00% 20 Missing โš ๏ธ
...ontroller/response/UserDetailAdminResponseDto.java 40.62% 18 Missing and 1 partial โš ๏ธ
... and 63 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #660      +/-   ##
============================================
+ Coverage     69.56%   74.12%   +4.55%     
+ Complexity      822      738      -84     
============================================
  Files           255      167      -88     
  Lines          3812     3181     -631     
  Branches        357      340      -17     
============================================
- Hits           2652     2358     -294     
+ Misses          955      679     -276     
+ Partials        205      144      -61     
Flag Coverage ฮ”
integrationTest 68.28% <68.42%> (-1.01%) โฌ‡๏ธ
unitTest 29.20% <26.51%> (+18.94%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@middlefitting middlefitting self-assigned this Feb 28, 2024
Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธ ์™„๋ฃŒ!

Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main ๋ธŒ๋žœ์น˜๊ฐ€ read only protect ๋˜๊ณ  ์žˆ์–ด์„œ ๋น„ํ™œ์„ฑํ™” ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค

@Kimhan-nah Kimhan-nah merged commit aa0c298 into main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants