-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 [Refactor] 토너먼트 진행 시간동안의 슬롯 블락 로직 삭제 #488
The head ref may contain hidden characters: "487-refactoring-\uD1A0\uB108\uBA3C\uD2B8-\uC9C4\uD589\uC2DC\uAC04\uC5D0-\uC2AC\uB86F-block-\uD480\uAE30"
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #488 +/- ##
============================================
+ Coverage 69.61% 70.10% +0.48%
- Complexity 822 848 +26
============================================
Files 255 255
Lines 3795 3860 +65
Branches 352 367 +15
============================================
+ Hits 2642 2706 +64
- Misses 950 951 +1
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 슬롯 블락은 언제 다시 할지 모르니 인터페이스 활용해서 구현체 갈아끼는 방식으로 진행해도 좋을 것 같아요.
📌 개요
💻 작업사항
💡Issue 번호