Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 [Refactor] 토너먼트 진행 시간동안의 슬롯 블락 로직 삭제 #488

Conversation

Kimhan-nah
Copy link
Member

@Kimhan-nah Kimhan-nah commented Jan 5, 2024

📌 개요

  • 토너먼트 진행 시간동안의 슬롯 블락 로직 삭제

💻 작업사항

  • 토너먼트 진행 시간동안의 슬롯 블락하는 로직 전체 삭제
  • 이후에 탁구대가 하나인 상황이 올 경우... 해당 코드 다시 추가하면 됩니다..ㅎㅎ

💡Issue 번호

@Kimhan-nah Kimhan-nah added the enhancement New feature or request label Jan 5, 2024
@Kimhan-nah Kimhan-nah self-assigned this Jan 5, 2024
@Kimhan-nah Kimhan-nah linked an issue Jan 5, 2024 that may be closed by this pull request
@Kimhan-nah Kimhan-nah changed the title 🔨 [Refactor] 토너먼트에 대한 슬롯 블락 삭제 🔨 [Refactor] 토너먼트 진행 시간동안의 슬롯 블락 로직 삭제 Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c895a3c) 69.61% compared to head (3c436eb) 70.10%.
Report is 9 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #488      +/-   ##
============================================
+ Coverage     69.61%   70.10%   +0.48%     
- Complexity      822      848      +26     
============================================
  Files           255      255              
  Lines          3795     3860      +65     
  Branches        352      367      +15     
============================================
+ Hits           2642     2706      +64     
- Misses          950      951       +1     
  Partials        203      203              
Flag Coverage Δ
integrationTest 69.81% <ø> (+0.49%) ⬆️
unitTest 10.12% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah requested a review from SONGS4RI January 6, 2024 07:42
@Kimhan-nah Kimhan-nah closed this Jan 12, 2024
@Kimhan-nah Kimhan-nah deleted the 487-refactoring-토너먼트-진행시간에-슬롯-block-풀기 branch January 12, 2024 08:12
@Kimhan-nah Kimhan-nah restored the 487-refactoring-토너먼트-진행시간에-슬롯-block-풀기 branch January 12, 2024 08:13
@Kimhan-nah Kimhan-nah reopened this Jan 12, 2024
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 슬롯 블락은 언제 다시 할지 모르니 인터페이스 활용해서 구현체 갈아끼는 방식으로 진행해도 좋을 것 같아요.

@Kimhan-nah Kimhan-nah merged commit 72d0406 into dev Jan 20, 2024
2 checks passed
@Kimhan-nah Kimhan-nah deleted the 487-refactoring-토너먼트-진행시간에-슬롯-block-풀기 branch January 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 [Refactoring] 토너먼트 진행시간에 슬롯 Block 풀기
4 participants