Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] module 이름 변경 #659

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[FEAT] module 이름 변경 #659

merged 2 commits into from
Feb 28, 2024

Conversation

wken5577
Copy link
Contributor

📌 개요

  • module 이름 변경했습니다

💻 작업사항

✅ 변경로직

💡Issue 번호

@wken5577 wken5577 self-assigned this Feb 28, 2024
@wken5577 wken5577 linked an issue Feb 28, 2024 that may be closed by this pull request
Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옮기는 김에 utils 에 있는 exception 도 api 모듈로 옮기면 어떨까요

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (3193717) to head (8f1d1ab).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #659       +/-   ##
=============================================
+ Coverage     10.25%   74.12%   +63.87%     
- Complexity       78      738      +660     
=============================================
  Files           255      167       -88     
  Lines          3812     3181      -631     
  Branches        357      340       -17     
=============================================
+ Hits            391     2358     +1967     
+ Misses         3410      679     -2731     
- Partials         11      144      +133     
Flag Coverage Δ
integrationTest 68.24% <ø> (?)
unitTest 29.20% <ø> (+18.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception 너무 여기저기서 참조되고 있긴 하네요
일단 확인

Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@wken5577 wken5577 merged commit da7fe73 into dev Feb 28, 2024
2 checks passed
@wken5577 wken5577 deleted the 658-feature-module-name branch February 29, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Module 이름 변경
4 participants