Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§ͺ [Unit Test] UserAuthenticationService ν…ŒμŠ€νŠΈ μ½”λ“œ #543

Conversation

middlefitting
Copy link
Member

@middlefitting middlefitting commented Feb 8, 2024

πŸ“Œ κ°œμš”

  • UserAuthenticationService ν…ŒμŠ€νŠΈμ½”λ“œ μž…λ‹ˆλ‹€.

πŸ’» μž‘μ—…μ‚¬ν•­

  • UserAuthenticationService.regenerate ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±, λ¬Έμ„œν™”

πŸ’‘Issue 번호

@middlefitting middlefitting self-assigned this Feb 8, 2024
@middlefitting middlefitting added documentation Improvements or additions to documentation test labels Feb 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 493 lines in your changes are missing coverage. Please review.

Comparison is base (3193717) 10.25% compared to head (84456a2) 74.07%.
Report is 21 commits behind head on dev.

Files Patch % Lines
...gg/server/admin/user/service/UserAdminService.java 44.57% 44 Missing and 2 partials ⚠️
...min/tournament/service/TournamentAdminService.java 81.48% 15 Missing and 15 partials ⚠️
...com/gg/server/domain/game/service/GameService.java 72.22% 15 Missing and 15 partials ⚠️
...erver/admin/season/service/SeasonAdminService.java 75.53% 9 Missing and 14 partials ⚠️
...gg/server/admin/game/service/GameAdminService.java 72.36% 11 Missing and 10 partials ⚠️
...ver/admin/user/controller/UserAdminController.java 51.35% 17 Missing and 1 partial ⚠️
.../gg/server/domain/match/utils/MatchCalculator.java 60.46% 10 Missing and 7 partials ⚠️
...n/java/com/gg/server/data/user/type/OauthType.java 0.00% 15 Missing ⚠️
...m/gg/server/domain/match/service/MatchService.java 85.84% 8 Missing and 7 partials ⚠️
...penalty/data/PenaltyAdminRepositoryCustomImpl.java 67.44% 14 Missing ⚠️
... and 57 more
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #543       +/-   ##
=============================================
+ Coverage     10.25%   74.07%   +63.81%     
- Complexity       78      890      +812     
=============================================
  Files           255      256        +1     
  Lines          3812     3934      +122     
  Branches        357      361        +4     
=============================================
+ Hits            391     2914     +2523     
+ Misses         3410      833     -2577     
- Partials         11      187      +176     
Flag Coverage Ξ”
integrationTest 70.08% <74.78%> (?)
unitTest 28.34% <34.10%> (+18.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!

@middlefitting middlefitting merged commit c311f57 into dev Feb 14, 2024
2 checks passed
@middlefitting middlefitting deleted the 542-test-userauthenticationservice-ν…ŒμŠ€νŠΈ-μ½”λ“œ branch February 14, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ§ͺ [Test] UserAuthenticationService ν…ŒμŠ€νŠΈ μ½”λ“œ
3 participants