Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿงช [Test] MatchFindService ๋‹จ์œ„ ํ…Œ์ŠคํŠธ #518

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

Kimhan-nah
Copy link
Member

@Kimhan-nah Kimhan-nah commented Jan 21, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • MatchFindService ๋‹จ์œ„ ํ…Œ์ŠคํŠธ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • MatchTournamentTest -> MatchTournamentServiceTest ํŒŒ์ผ๋ช… ์ˆ˜์ •
  • matchFindService์—์„œ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” tournamentRepository ์‚ญ์ œ
  • MatchFindServiceUnitTest ์ถ”๊ฐ€
    • service๊ฐ€ ์—ฌ๋Ÿฌ๊ฐœ ์กด์žฌํ•˜๋Š”๋ฐ ํ˜„์žฌ MatchFindService๋งŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
    • TODO ์ฃผ์„์€ ์ดํ›„ ๋‹ค๋ฅธ ์„œ๋น„์Šค ๋‹จ์œ„ ํ…Œ์ŠคํŠธ ๊ตฌํ˜„ํ•˜๋ฉด์„œ ์‚ญ์ œํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@Kimhan-nah Kimhan-nah self-assigned this Jan 21, 2024
@Kimhan-nah Kimhan-nah linked an issue Jan 21, 2024 that may be closed by this pull request
11 tasks
@Kimhan-nah Kimhan-nah changed the title ๐Ÿงช [Test] ๐Ÿงช [Test] MatchFindService ๋‹จ์œ„ ํ…Œ์ŠคํŠธ Jan 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Comparison is base (3193717) 10.25% compared to head (46b36cb) 69.89%.
Report is 4 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #518       +/-   ##
=============================================
+ Coverage     10.25%   69.89%   +59.64%     
- Complexity       78      823      +745     
=============================================
  Files           255      255               
  Lines          3812     3797       -15     
  Branches        357      356        -1     
=============================================
+ Hits            391     2654     +2263     
+ Misses         3410      934     -2476     
- Partials         11      209      +198     
Flag Coverage ฮ”
integrationTest 69.47% <รธ> (?)
unitTest 14.53% <รธ> (+4.28%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah marked this pull request as ready for review January 21, 2024 06:04
Copy link
Member

@kokomong2 kokomong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ผผ๊ผผํ•˜๊ฒŒ ์ž˜ ์งœ์‹ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ˆ˜๊ณ ๋งŽ์œผ์…จ์–ด์š”!

@Kimhan-nah Kimhan-nah merged commit 51d81b8 into dev Jan 27, 2024
1 check passed
@Kimhan-nah Kimhan-nah deleted the 464-test-match branch January 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๐Ÿงช [Test] Match ํ…Œ์ŠคํŠธ ์ฝ”๋“œ
4 participants