Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #232 admin 게임 관리 페이지에서 점수 수정 시 승패 수정 안되는 문제 #473

Conversation

AYoungSn
Copy link
Contributor

@AYoungSn AYoungSn commented Jan 2, 2024

📌 개요

  • 점수 수정 시 redis 와 db (ranks, pchange) 테이블 값이 일치하지 않는 문제를 수정했습니다.

✅ 변경로직

  • game 점수 수정 시 db에서 티어 수정 안되는 문제 수정
  • ranking ppp, tier 꼬이는 문제를 수정했습니다

💡Issue 번호

@AYoungSn AYoungSn self-assigned this Jan 2, 2024
@AYoungSn AYoungSn added the bug Something isn't working label Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3193717) 10.25% compared to head (6ac04bb) 69.84%.
Report is 6 commits behind head on dev.

Files Patch % Lines
...gg/server/admin/game/service/GameAdminService.java 78.26% 2 Missing and 3 partials ⚠️
...main/season/exception/SeasonNotFoundException.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #473       +/-   ##
=============================================
+ Coverage     10.25%   69.84%   +59.58%     
- Complexity       78      825      +747     
=============================================
  Files           255      255               
  Lines          3812     3820        +8     
  Branches        357      357               
=============================================
+ Hits            391     2668     +2277     
+ Misses         3410      944     -2466     
- Partials         11      208      +197     
Flag Coverage Δ
integrationTest 69.55% <84.44%> (?)
unitTest 10.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SONGS4RI
SONGS4RI previously approved these changes Jan 4, 2024
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다!!

…ev.v2 into 232-fix-admin-게임-관리-페이지에서-점수-수정-시-승패-수정-안되는-문제
middlefitting
middlefitting previously approved these changes Jan 17, 2024
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

…ev.v2 into 232-fix-admin-게임-관리-페이지에서-점수-수정-시-승패-수정-안되는-문제
@SONGS4RI SONGS4RI self-requested a review January 24, 2024 11:38
SONGS4RI
SONGS4RI previously approved these changes Jan 24, 2024
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DynamicUpdate 배워갑니닷

@AYoungSn AYoungSn merged commit f767c25 into dev Jan 27, 2024
1 check passed
@AYoungSn AYoungSn deleted the 232-fix-admin-게임-관리-페이지에서-점수-수정-시-승패-수정-안되는-문제 branch January 27, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants