[Main][Xcode12] Add support for Xcode 12 #9692

mandel-macaque · 2020-09-24T02:00:07Z

No description provided.

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

Some backlog from Xcode11 still exists and requires generator changes Tracked in #8943

The framework is not available (binary or even headers) for the iOS simulator, only devices. As such `tools/mtouch/Makefile` is not updated with a `-weak-framework` Tracked with * https://github.com/xamarin/maccore/issues/2266 * https://feedbackassistant.apple.com/feedback/8001312

New commits in xamarin/maccore: * xamarin/maccore@61fa67753c [install-qa-provisioning-profiles] Don't try to touch a directory that doesn't exist. (#2268) Diff: https://github.com/xamarin/maccore/compare/e6eed65b74728cab3093697711eb5ed4ffed772e..61fa67753cd6145e7f52e501127956f1d409a82a

* [AppKit] Xcode 12.0 Beta 1 * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> Co-authored-by: Alex Soto <[email protected]> * More code review changes * Apply suggestions from code review Co-authored-by: Alex Soto <[email protected]> * Code review changes * Apply suggestions from code review Co-authored-by: Whitney Schmidt <[email protected]> * Remove unnecessary 10.7 mac attribute Co-authored-by: Rolf Bjarne Kvinge <[email protected]> Co-authored-by: Alex Soto <[email protected]> Co-authored-by: Whitney Schmidt <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

… for inputs (#9134) * [msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs From Visual Studio we need the input files to be instead of plain strings to identify the files that need to be copied to the Mac * Adds null check for AppManifest in GetMinimumOSVersionTaskBase

`GetMinimumOSVersion` should not be run if there's no Mac available because it depends on `_DetectSdkLocations` to calculate the value of `_SdkVersion`, and this will only happen if there's a Mac connected. This change fixes offline builds (plain IL builds) and Hot Restart builds on Windows.

* bump APIDIFF_REFERENCES Co-authored-by: Whitney Schmidt <[email protected]>

Fixes https://developercommunity.visualstudio.com/content/problem/934833/xamarinforms-cant-create-archive-for-ios.html Depending on the default language of the running OS this could cause translating AM/PM to symbols that are not supported on folder names on Windows. For instance, the value of `timestamp` without this change for an user that sets Chinese as it's main language would be `8-18-15 1.31 下午`, where `下午` represent PM.

* Disable iOS 32bits simulator based tests

Apple removed the 10.16 API instead of marking them for 11.0 ?!?

monojenkins · 2020-09-24T02:18:54Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

rolfbjarne · 2020-09-24T06:59:30Z

.gitmodules

@@ -1,7 +1,7 @@
 [submodule "external/macios-binaries"]
    path = external/macios-binaries
    url = ../../xamarin/macios-binaries
-    branch = main
+    branch = d16-8 


This isn't quite right.

@rolfbjarne We can't build binaries with Mac build disabled unless you think we should just merge branches in macios-binaries (d16-8 => main) I do not see another workaround

Yes, I'd say we merge d16-8 into main in macios-binaries.

spouliot · 2020-09-24T12:41:46Z

Make.config

@@ -111,9 +111,9 @@ WATCHOS_NUGET_VERSION_NO_METADATA=$(WATCHOS_NUGET_VERSION)-$(NUGET_PRERELEASE_ID
 WATCHOS_NUGET_VERSION_FULL=$(WATCHOS_NUGET_VERSION_NO_METADATA)+$(NUGET_BUILD_METADATA)

 # Xcode version should have both a major and a minor version (even if the minor version is 0)
-XCODE_VERSION=11.6


APIDIFF_REFERENCES= (earlier, around line 34) should also be updated to point to XI 14.0 stable release

spouliot · 2020-09-24T12:44:08Z

msbuild/Xamarin.Shared/Xamarin.Shared.targets

+			</_AppExtensionCodesignProperties> 
+		</ItemGroup>
+	</Target>
+


IIRC that was already in main and backported into xcode12, c.c. @chamons
are sure you're not duplicating the logic ?

You are correct, appears twice in the file, removing.

monojenkins · 2020-09-24T15:40:13Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

monojenkins · 2020-09-24T15:54:45Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

monojenkins · 2020-09-24T16:10:37Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

monojenkins · 2020-09-24T20:15:07Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

6 tests failed, 111 tests passed.

Failed tests

interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
dont link/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
dont link/iOS Unified 64-bits - simulator/Release [dotnet]: Crashed
DotNet tests: Failed (Execution failed with exit code 1)

monojenkins · 2020-09-25T01:13:37Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

5 tests failed, 112 tests passed.

Failed tests

interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
dont link/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
dont link/iOS Unified 64-bits - simulator/Release [dotnet]: Crashed

…fix selecting whether a framework should be linked weakly or not in dotnet-linker. This fixes a startup crash in the simulator with Xcode 12: Library not loaded: /usr/lib/libnfshared.dylib Referenced from: /Applications/Xcode_12.0.0-GMb.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreNFC.framework/CoreNFC Reason: no suitable image found. Did find: /usr/lib/libnfshared.dylib: mach-o, but not built for platform iOS-sim Ref: https://stackoverflow.com/q/63915728/183422

monojenkins · 2020-09-25T13:46:12Z

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

mandel-macaque and others added 30 commits July 15, 2020 16:29

[Accessibility] Add new Framework from Xcode 12 beta 1. (#9086)

2b35db0

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

[foundation] Update for Xcode12 beta 2 (#9095)

3c2e4d6

Some backlog from Xcode11 still exists and requires generator changes Tracked in #8943

[authenticationservices] Update for Xcode 12 beta 2 (#9099)

376ad74

[CoreNFC] Add support for xcode 12 beta 1. (#9089)

f5d61b4

[wkwebkit] Update for Xcode 12 beta 2 (#9113)

59bd868

[coreml] Update for Xcode 12 beta 2 (#9124)

1966e15

[xcode11.6] Initial bump to support Xcode 11.6 Beta 1

772e651

[xcode11.6] Bump to final version of Xcode 11.6 (#9112)

0221d22

[naturallanguage] Update for Xcode 12 beta 2 (#9133)

38fb101

[mediaplayer] Update for Xcode 12 beta 2 (#9136)

819acda

[sensorkit] Update for Xcode 12 beta 2 (#9142)

f36b2ae

[devicecheck] Update for Xcode 12 beta 2 (#9145)

5cdfa2e

[xcode12] Bump API diff to latest released stable (#9155)

c0ccff8

* bump APIDIFF_REFERENCES Co-authored-by: Whitney Schmidt <[email protected]>

[d16-8] Bump API diff to latest released stable (#9154)

33aeafe

* bump APIDIFF_REFERENCES Co-authored-by: Whitney Schmidt <[email protected]>

[corewlan] Update for Xcode 12 beta 2 (#9156)

52e51bc

[metrickit] Update for Xcode 12 beta 2 (#9151)

038db0f

[xcode12] Bump for beta 3 (#9162)

142ff31

* Disable iOS 32bits simulator based tests

[wkwebkit] Update for Xcode 12 beta 3 (#9178)

1497988

[uniformtypeidentifiers] Update for Xcode 12 beta 3 (#9181)

04e8447

[usernotifications] Update for Xcode 12 beta 3 (#9183)

ad03ffb

[usernotificationsui] Update for Xcode 12 beta 3 (#9184)

fd7b9c1

[corebluetooth] Update for Xcode 12 beta 3 (#9186)

e47e10a

Apple removed the 10.16 API instead of marking them for 11.0 ?!?

[imageio] Update Xcode 12 beta 3 (#9189)

bcfd8a4

mandel-macaque requested review from dalexsoto, emaf, rolfbjarne and spouliot as code owners September 24, 2020 02:00

rolfbjarne requested changes Sep 24, 2020

View reviewed changes

spouliot suggested changes Sep 24, 2020

View reviewed changes

mandel-macaque added 4 commits September 24, 2020 10:47

[Xamarin.MacDev][macios-binaries] Bump to pick changes from xcode12.

03b583d

Fix wrong merge in tests.

b6b825e

[ApiDiff] Bump api diff ref to Xcode 12.

a1cbd72

[MSbuild] Remove duplicated target.

591c28d

spouliot approved these changes Sep 24, 2020

View reviewed changes

[xtro] Fix osome ignores.

34fc106

rolfbjarne approved these changes Sep 24, 2020

View reviewed changes

[Localizations] Update Errors.cs with the new error.

c962651

whitneyschmidt requested a review from tj-devel709 September 24, 2020 17:43

whitneyschmidt approved these changes Sep 24, 2020

View reviewed changes

tj-devel709 approved these changes Sep 24, 2020

View reviewed changes

[DotNet] Ignore those tests that require Mac OS X if not enabled.

022f5d3

rolfbjarne mentioned this pull request Sep 25, 2020

Add C# 8 nullability annotations to bindings #6154

Open

dalexsoto approved these changes Sep 25, 2020

View reviewed changes

mandel-macaque merged commit 764734d into main Sep 25, 2020

mandel-macaque deleted the main-xcode12 branch September 25, 2020 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Main][Xcode12] Add support for Xcode 12 #9692

[Main][Xcode12] Add support for Xcode 12 #9692

mandel-macaque commented Sep 24, 2020

monojenkins commented Sep 24, 2020

rolfbjarne Sep 24, 2020

dalexsoto Sep 24, 2020

rolfbjarne Sep 24, 2020 •

edited

Loading

spouliot Sep 24, 2020

spouliot Sep 24, 2020

mandel-macaque Sep 24, 2020

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

Failed tests

monojenkins commented Sep 25, 2020

Failed tests

monojenkins commented Sep 25, 2020

[Main][Xcode12] Add support for Xcode 12 #9692

[Main][Xcode12] Add support for Xcode 12 #9692

Conversation

mandel-macaque commented Sep 24, 2020

monojenkins commented Sep 24, 2020

rolfbjarne Sep 24, 2020

Choose a reason for hiding this comment

dalexsoto Sep 24, 2020

Choose a reason for hiding this comment

rolfbjarne Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

spouliot Sep 24, 2020

Choose a reason for hiding this comment

spouliot Sep 24, 2020

Choose a reason for hiding this comment

mandel-macaque Sep 24, 2020

Choose a reason for hiding this comment

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

monojenkins commented Sep 24, 2020

Test results

Failed tests

monojenkins commented Sep 25, 2020

Test results

Failed tests

monojenkins commented Sep 25, 2020

rolfbjarne Sep 24, 2020 •

edited

Loading