Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devicecheck] Update for Xcode 12 beta 2 #9145

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[devicecheck] Update for Xcode 12 beta 2 #9145

merged 2 commits into from
Jul 21, 2020

Conversation

spouliot
Copy link
Contributor

No description provided.

@spouliot spouliot added this to the xcode12 milestone Jul 21, 2020
rolfbjarne
rolfbjarne approved these changes Jul 21, 2020
View reviewed changes
src/devicecheck.cs
FeatureUnsupported
FeatureUnsupported,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many years it'll take us to add a trailing comma everywhere...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely a few more once sharpie output them correctly ;-)
c.c. @dalexsoto

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh maybe that would require some Roslyn 🙈

dalexsoto
dalexsoto approved these changes Jul 21, 2020
View reviewed changes
src/devicecheck.cs Outdated

[Async]
[Export ("generateKeyWithCompletionHandler:")]
void GenerateKey (Action<NSString, NSError> completionHandler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for NSString here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, missed it :)

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@spouliot spouliot merged commit 5cdfa2e into xamarin:xcode12 Jul 21, 2020
@spouliot spouliot deleted the xcode12-devicecheck-b2 branch July 21, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
xcode12
Development

Successfully merging this pull request may close these issues.
5 participants
@spouliot @monojenkins @dalexsoto @rolfbjarne @whitneyschmidt