[AppKit] Xcode 12.0 Beta 1 #9106

chamons · 2020-07-16T15:03:50Z

No description provided.

spouliot · 2020-07-16T15:11:26Z

src/AppKit/Enums.cs

+		Small = 1,
+		Mini = 2,
+		[Mac (10,16)]
+		Large = 3


minor: add a , so any future addition won't make the last value part of the diff

spouliot · 2020-07-16T15:11:42Z

src/AppKit/Enums.cs

+		Automatic,
+		FullWidth,
+		Inset,
+		SourceList


minor: add a , so any future addition won't make the last value part of the diff

spouliot · 2020-07-16T15:11:48Z

src/AppKit/Enums.cs

+		Automatic,
+		None,
+		Line,
+		Shadow


minor: add a , so any future addition won't make the last value part of the diff

spouliot · 2020-07-16T15:12:03Z

src/AppKit/Enums.cs

+		Expanded,
+		Preference,
+		Unified,
+		UnifiedCompact


minor: add a , so any future addition won't make the last value part of the diff

spouliot · 2020-07-16T15:12:18Z

src/AppKit/Enums.cs

+		SlideUp = 0x10,
+		SlideDown = 0x20,
+		SlideLeft = 0x30,
+		SlideRight = 0x40


minor: add a , so any future addition won't make the last value part of the diff

spouliot · 2020-07-16T15:27:37Z

src/appkit.cs

+		NSTextContentTypePassword,
+
+		[Field ("NSTextContentTypeOneTimeCode")]
+		NSTextContentTypeOneTimeCode,


spouliot · 2020-07-16T15:28:19Z

src/appkit.cs

+
+		[Static]
+		[Export ("tintConfigurationWithPreferredColor:")]
+		NSTintConfiguration TintConfigurationWithPreferredColor (NSColor color);


no verb -> CreateWithPreferredColor

spouliot · 2020-07-16T15:28:35Z

src/appkit.cs

+
+		[Static]
+		[Export ("tintConfigurationWithFixedColor:")]
+		NSTintConfiguration TintConfigurationWithFixedColor (NSColor color);


no verb -> CreateWithFixedColor

src/appkit.cs

dalexsoto

Some changes required

src/AppKit/Enums.cs

dalexsoto · 2020-07-16T15:14:25Z

src/AppKit/Enums.cs

+		Automatic,
+		FullWidth,
+		Inset,
+		SourceList


Suggested change

SourceList

SourceList,

dalexsoto · 2020-07-16T15:14:34Z

src/AppKit/Enums.cs

+		Automatic,
+		None,
+		Line,
+		Shadow


Suggested change

Shadow

Shadow,

dalexsoto · 2020-07-16T15:14:42Z

src/AppKit/Enums.cs

+		Expanded,
+		Preference,
+		Unified,
+		UnifiedCompact


Suggested change

UnifiedCompact

UnifiedCompact,

dalexsoto · 2020-07-16T15:14:55Z

src/AppKit/Enums.cs

+		SlideUp = 0x10,
+		SlideDown = 0x20,
+		SlideLeft = 0x30,
+		SlideRight = 0x40


Suggested change

SlideRight = 0x40

SlideRight = 0x40,

src/appkit.cs

whitneyschmidt

LGTM after Sebastien suggestions :)

rolfbjarne

Just a few minor issues.

rolfbjarne · 2020-07-16T15:36:24Z

src/appkit.cs

 		NSColor Knob { get; }

 		[Static]
 		[Export ("selectedKnobColor")]
-		[Advice ("Use 'NSScroller' instead")]
+		[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'NSScroller' instead")]


Suggested change

[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'NSScroller' instead")]

[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'NSScroller' instead.")]

rolfbjarne · 2020-07-16T15:37:24Z

src/appkit.cs

+		[Static]
+		[Export ("imageWithSystemSymbolName:accessibilityDescription:")]
+		[return: NullAllowed]
+		NSImage GetSystemSymbol (string symbolName, [NullAllowed] string description);


Suggested change

NSImage GetSystemSymbol (string symbolName, [NullAllowed] string description);

NSImage GetSystemSymbol (string symbolName, [NullAllowed] string accessibilityDescription);

src/appkit.cs

rolfbjarne · 2020-07-16T15:39:27Z

src/appkit.cs

+		void ApplySnapshot (NSDiffableDataSourceSnapshot<NSObject, NSObject> snapshot, bool animatingDifferences);
+
+		[Export ("applySnapshot:animatingDifferences:completion:")]
+		void ApplySnapshot (NSDiffableDataSourceSnapshot<NSObject, NSObject> snapshot, bool animatingDifferences, [NullAllowed] Action completion);


+[Async]?

spouliot · 2020-07-16T15:40:33Z

src/AppKit/Enums.cs

+
+	[Flags, Mac (10,16)]
+	[Native]
+	public enum NSTableViewAnimationOptions : ulong


weird, it's not in the diff
it's used but not defined, maybe it's an older type ?

[Flags, NoiOS, Mac (0xa,0x7)]
10.7
https://github.com/xamarin/ObjectiveSharpie/issues/139

Co-authored-by: Rolf Bjarne Kvinge <[email protected]> Co-authored-by: Alex Soto <[email protected]>

monojenkins · 2020-07-16T16:00:34Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

monojenkins · 2020-07-16T16:10:11Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

Co-authored-by: Alex Soto <[email protected]>

src/appkit.cs

spouliot · 2020-07-16T17:23:32Z

src/appkit.cs

+	[Mac (10,16)]
+	[BaseType (typeof(NSObject))]
+	[DisableDefaultCtor]
+	interface NSTableViewDiffableDataSource : NSTableViewDataSource


that does not match the native side

@interface NSTableViewDiffableDataSource<SectionIdentifierType,ItemIdentifierType> : NSObject<NSTableViewDataSource>

and that's a similar issue to what we had in Foundation (and UIKit) that requires generator changes (iirc from last year)

spouliot · 2020-07-16T17:24:05Z

src/appkit.cs

+		IntPtr Constructor (NSTableView tableView, NSTableViewDiffableDataSourceCellProvider cellProvider);
+
+		[Export ("snapshot")]
+		NSDiffableDataSourceSnapshot<NSObject, NSObject> Snapshot ();


NSObject are wrong since it should be identical to the generic used on the type itself

monojenkins · 2020-07-16T19:01:23Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 92 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.)

src/AppKit/NSWorkspace.cs

src/appkit.cs

whitneyschmidt · 2020-07-16T20:43:58Z

src/appkit.cs

+		[Static]
+		[Export ("imageWithSystemSymbolName:accessibilityDescription:")]
+		[return: NullAllowed]
+		NSImage GetSystemSymbol (string symbolName, [NullAllowed] string accessibilityDescription);


GetSystemSymbolImage since we're returning an NSImage?

We are inside NSImage already so it's NSImage.GetSystemSymbol()

Co-authored-by: Whitney Schmidt <[email protected]>

monojenkins · 2020-07-16T20:57:14Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

monojenkins · 2020-07-16T23:54:45Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 92 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.)

spouliot · 2020-07-17T00:33:22Z

8:49:40.1399010 [FAIL] 10.7 < 10.9 (Min) on 'AppKit.NSTableViewAnimationOptions'.

we don't add availability when older than our minimum supported version

chamons · 2020-07-17T14:02:46Z

I remember when 10.7 was supported... Fixing.

monojenkins · 2020-07-17T20:12:43Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

[AppKit] Xcode 12.0 Beta 1

5af0244

chamons requested review from dalexsoto and spouliot as code owners July 16, 2020 15:03

spouliot suggested changes Jul 16, 2020

View reviewed changes

dalexsoto requested changes Jul 16, 2020

View reviewed changes

whitneyschmidt approved these changes Jul 16, 2020

View reviewed changes

rolfbjarne approved these changes Jul 16, 2020

View reviewed changes

spouliot reviewed Jul 16, 2020

View reviewed changes

Apply suggestions from code review

2296d72

Co-authored-by: Rolf Bjarne Kvinge <[email protected]> Co-authored-by: Alex Soto <[email protected]>

More code review changes

f8fde5e

Apply suggestions from code review

e9dc224

Co-authored-by: Alex Soto <[email protected]>

spouliot suggested changes Jul 16, 2020

View reviewed changes

Code review changes

b749937

whitneyschmidt approved these changes Jul 16, 2020

View reviewed changes

Apply suggestions from code review

51a6f04

Co-authored-by: Whitney Schmidt <[email protected]>

spouliot approved these changes Jul 17, 2020

View reviewed changes

Remove unnecessary 10.7 mac attribute

0f412b4

whitneyschmidt approved these changes Jul 17, 2020

View reviewed changes

mandel-macaque approved these changes Jul 17, 2020

View reviewed changes

dalexsoto approved these changes Jul 17, 2020

View reviewed changes

chamons merged commit fbcbdcd into xamarin:xcode12 Jul 17, 2020

chamons deleted the xcode12-appkit-b1 branch July 17, 2020 20:19

chamons added the notes-mention Deserves a mention in release notes label Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AppKit] Xcode 12.0 Beta 1 #9106

[AppKit] Xcode 12.0 Beta 1 #9106

chamons commented Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

dalexsoto left a comment

dalexsoto Jul 16, 2020

dalexsoto Jul 16, 2020

dalexsoto Jul 16, 2020

dalexsoto Jul 16, 2020

whitneyschmidt left a comment

rolfbjarne left a comment

rolfbjarne Jul 16, 2020

rolfbjarne Jul 16, 2020

rolfbjarne Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

monojenkins commented Jul 16, 2020

monojenkins commented Jul 16, 2020

spouliot Jul 16, 2020

spouliot Jul 16, 2020

monojenkins commented Jul 16, 2020

Failed tests

whitneyschmidt Jul 16, 2020

chamons Jul 16, 2020

monojenkins commented Jul 16, 2020

monojenkins commented Jul 16, 2020

Failed tests

spouliot commented Jul 17, 2020

chamons commented Jul 17, 2020

monojenkins commented Jul 17, 2020

	[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'NSScroller' instead")]
	[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'NSScroller' instead.")]

	NSImage GetSystemSymbol (string symbolName, [NullAllowed] string description);
	NSImage GetSystemSymbol (string symbolName, [NullAllowed] string accessibilityDescription);

[AppKit] Xcode 12.0 Beta 1 #9106

[AppKit] Xcode 12.0 Beta 1 #9106

Conversation

chamons commented Jul 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whitneyschmidt left a comment

Choose a reason for hiding this comment

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 16, 2020

monojenkins commented Jul 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 16, 2020

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 16, 2020

monojenkins commented Jul 16, 2020

Test results

Failed tests

spouliot commented Jul 17, 2020

chamons commented Jul 17, 2020

monojenkins commented Jul 17, 2020