Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d16-8][msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs #9134

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Jul 20, 2020

From Visual Studio we need the input files to be instead of plain strings to identify the files that need to be copied to the Mac

…puts

From Visual Studio we need the input files to be  instead of plain strings to identify the files that need to be copied to the Mac
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we backport this one to the main branch?

@emaf emaf changed the title [msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs [d16-8][msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs Jul 20, 2020
@emaf
Copy link
Contributor Author

emaf commented Jul 20, 2020

@monojenkins backport main

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

50 tests failed, 40 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/tvOS - simulator/Debug: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure
  • dont link/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 32-bits - simulator/Release: BuildFailure
  • dont link/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
  • dont link/tvOS - simulator/Debug: BuildFailure
  • dont link/tvOS - simulator/Release: BuildFailure
  • dont link/watchOS 32-bits - simulator/Debug: BuildFailure
  • dont link/watchOS 32-bits - simulator/Release: BuildFailure
  • link all/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • link all/iOS Unified 32-bits - simulator/Release: BuildFailure
  • link all/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • link all/iOS Unified 64-bits - simulator/Release: BuildFailure
  • link all/tvOS - simulator/Debug: BuildFailure
  • link all/tvOS - simulator/Release: BuildFailure
  • link all/watchOS 32-bits - simulator/Debug: BuildFailure
  • link all/watchOS 32-bits - simulator/Release: BuildFailure
  • link sdk/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • link sdk/iOS Unified 32-bits - simulator/Release: BuildFailure
  • link sdk/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • link sdk/iOS Unified 64-bits - simulator/Release: BuildFailure
  • link sdk/tvOS - simulator/Debug: BuildFailure
  • link sdk/tvOS - simulator/Release: BuildFailure
  • link sdk/watchOS 32-bits - simulator/Debug: BuildFailure
  • link sdk/watchOS 32-bits - simulator/Release: BuildFailure
  • framework-test/tvOS - simulator/Debug: BuildFailure
  • interdependent-binding-projects/tvOS - simulator/Debug: BuildFailure
  • fsharp/tvOS - simulator/Debug: BuildFailure
  • introspection/tvOS - simulator/Debug: BuildFailure
  • mono-native-compat/tvOS - simulator/Debug: BuildFailure
  • mono-native-unified/tvOS - simulator/Debug: BuildFailure
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 6)
  • MSBuild tests/macOS/Debug: Failed (Execution failed with exit code 5)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 21)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 9)

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 89 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed Known issue: HE0038)

@rolfbjarne rolfbjarne merged commit 914cdaa into xamarin:d16-8 Jul 21, 2020
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants