Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d16-8][msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs #9134

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[d16-8][msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs #9134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
466e414
[msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for in…
emaf Jul 20, 2020
770f068
Adds null check for AppManifest in GetMinimumOSVersionTaskBase
emaf Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions msbuild/Xamarin.MacDev.Tasks.Core/Tasks/GetMinimumOSVersionTaskBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace Xamarin.MacDev.Tasks {
public abstract class GetMinimumOSVersionTaskBase : XamarinTask {
public string AppManifest { get; set; }
public ITaskItem AppManifest { get; set; }

[Required]
public string SdkVersion { get; set; }
Expand All @@ -18,9 +18,9 @@ public override bool Execute ()
{
PDictionary plist = null;

if (!string.IsNullOrEmpty (AppManifest)) {
if (!string.IsNullOrEmpty (AppManifest?.ItemSpec)) {
try {
plist = PDictionary.FromFile (AppManifest);
plist = PDictionary.FromFile (AppManifest.ItemSpec);
} catch (Exception ex) {
Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, MSBStrings.E0010, AppManifest, ex.Message);
return false;
Expand Down