[MPSCore] Update for Xcode 11 beta 1 to 7 #6935

praeclarum · 2019-09-07T05:04:39Z

This updates all the APIs to beta7.

Notes:

MPSCommandBuffer wraps an IMTLCommandBuffer - I think I got it right but please check (it's important).
MPSNDArray is the big new data type that is similar to MPSMatrix and MPSImage.
MPSNDArray has some methods that optionally return strides. I offer 3 versions of those functions: parameterless, IntPtr, and nint[].
MPSNDArray.WriteBytes buffer is an IntPtr which isn't ideal. But NDArrays can be any
data type so the alternative is to write primitive type overloads. I'm putting the burden on the app developer to fixed their data.
MPSNDArrayAllocators aren't really user definable but I wasn't able to get NSCopying and friends working without the [Model]
This also removes MetalPerformanceShaders from Dlfcn as it was conflicting with the one defined in Libraries.g.cs

This also removes the hardcoded MetalPerformanceShaders library from Dlfcn as it conflicted with Libraries.g.cs

monojenkins · 2019-09-07T08:16:23Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

8 tests failed, 83 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.)
Xtro/Mac: BuildFailure
introspection/iOS Unified 32-bits - simulator/Debug: Failed
introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): Failed
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed

dalexsoto

Looking good ❤️

dalexsoto · 2019-09-07T08:20:29Z

src/MetalPerformanceShaders/MPSKernel.cs

+		static extern MPSImageType MPSGetImageType (IntPtr image);
+
+		[iOS (13,0), TV (12,0), Mac (10,15)][Introduced (PlatformName.MacCatalyst, 13, 0)]
+		public MPSImageType ImageType => MPSGetImageType (Handle);


mmm this reminds me a little of #6530 (Which I still need to fix heh).
Will the property it be safe for the debugger?
what happens if Handle is invalid (IntPtr.Zero)?

Fair :-)

Yes it's safe because, ImageType is just an integer. I think that this is good info to have when you're in the debugger, that's why I made it a property.

The argument is marked nonnull so I assume bad things if null is passed. FWIW, I don't know if any NSObject properties are protected from Zero Handles.

I think this is fine, but I also don't think this function will be used a lot in real code, so I won't push the property.

src/metalperformanceshaders.cs

dalexsoto · 2019-09-07T08:38:21Z

src/metalperformanceshaders.cs

+		void Reshape (nuint numberOfDimensions, IntPtr dimensionSizes);
+
+		[Export ("reshapeWithShape:")]
+		void Reshape (NSNumber[] shape);


could this be a more concrete type? do you happen to know? if you do then you can do something like this

void Reshape ([BindAs (typeof (nint []))] NSNumber[] shape);

BindAs docs https://docs.microsoft.com/en-us/xamarin/cross-platform/macios/binding/objective-c-libraries?tabs=macos#binding-nsvalue-nsnumber-and-nsstring-to-a-better-type

Ah, no I didn't know that, thanks!

Thing is, I really want params for these puppies and that's why I provided the params version in manual code. Is there an attribute to get params?

Co-Authored-By: Alex Soto <[email protected]>

monojenkins · 2019-09-07T14:55:03Z

Build failure
❌ Build failed or was aborted

monojenkins · 2019-09-07T14:55:03Z

Build failure
❌ Build failed or was aborted

Co-Authored-By: Alex Soto <[email protected]>

monojenkins · 2019-09-07T15:05:03Z

Build failure
❌ Build failed or was aborted

monojenkins · 2019-09-07T17:41:11Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

8 tests failed, 83 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.)
Xtro/Mac: BuildFailure
introspection/iOS Unified 32-bits - simulator/Debug: Failed
introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): Failed
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed

rolfbjarne · 2019-09-09T13:37:31Z

src/MetalPerformanceShaders/MPSNDArray.cs

@@ -0,0 +1,90 @@
+#if (XAMCORE_2_0 && !MONOMAC) && !XAMCORE_4_0


This #if condition looks a bit weird, !XAMCORE_4_0 is used for API we'll want to remove in the future.

Exactly which are the circumstances you wanted to include/exclude?

I'll be honest I have no idea what any of these defines mean. I stole them from MPSMatrixDescriptor.cs.

MPS files use a combination of:

#if (XAMCORE_2_0 && !MONOMAC) && !XAMCORE_4_0

and

#if XAMCORE_2_0 || !MONOMAC

I would like to include every platform. So I'm guessing XAMCORE_2_0 || !MONOMAC is the one I want? Are those just guarding against the old APIs?

Just remove the entire #if ... condition, as far as I can tell it should be fine.

rolfbjarne · 2019-09-09T13:38:13Z

src/MetalPerformanceShaders/MPSNDArray.cs

+		public unsafe static MPSNDArrayDescriptor Create (MPSDataType dataType, params nuint[] dimensionSizes)
+		{
+			fixed (nuint* p = dimensionSizes) {
+				return Create (dataType, (nuint)dimensionSizes.Length, (IntPtr)p);


NullReferenceException if dimensionSizes is null. This method needs an argument check that throws an ArgumentNullException.

rolfbjarne · 2019-09-09T13:38:21Z

src/MetalPerformanceShaders/MPSNDArray.cs

+		public unsafe void Reshape (params nuint[] dimensionSizes)
+		{
+			fixed (nuint* p = dimensionSizes) {
+				Reshape ((nuint)dimensionSizes.Length, (IntPtr)p);


NullReferenceException if dimensionSizes is null. This method needs an argument check that throws an ArgumentNullException.

praeclarum · 2019-11-11T16:48:23Z

@rolfbjarne @dalexsoto Can you recommend how to proceed with this PR given that this branch has been released? Should I rebase to master and force push? Or start a new PR?

rolfbjarne · 2019-11-12T06:26:34Z

@praeclarum I think it's best to rebase on the master branch and creating a new PR is the best way to go (alternatively rebase on the xcode11.3 branch, which will get the PR in a stable release faster, but the down side is that the code will get less tested before it's released).

praeclarum · 2019-11-15T19:52:18Z

OK, will open a new PR against xcode11.3

This includes updates from PRs xamarin#6932 and xamarin#6935 It adds new functionality to the neural network components. This is still not the complete API for 11.3

@rolfbjarne

Co-Authored-By: Frank A. Krueger <[email protected]> This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

…#8844) * [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

…#8844) * [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

…#8844) * [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

…#8844) * [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs xamarin#6932, xamarin#6935 and xamarin#7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

@rolfbjarne

* [MetalPerformanceShaders] Neural Networks Update to Xcode 11 This includes updates from PRs #6932, #6935 and #7461 It adds new functionality to the neural network components. This is still not the complete API for 11.3 * Update src/metalperformanceshaders.cs Co-Authored-By: Rolf Bjarne Kvinge <[email protected]> * Make changes requested by @rolfbjarne * Fix binding of default random distribution creation The parameterless function creates new default distributions and is not a property. It is a counterpart of CreateUniform. * Expose public APIs for MPSCnnConvolutionTransposeNode These APIs are public and documented at: https://developer.apple.com/documentation/metalperformanceshaders/mpscnnconvolutiontransposenode/2942641-initwithsource?language=objc I have also tested that they work. * Reintroduce compat API. * Fix acronym casing. * Fix introspection tests. * Fix xtro. * One last xtro issue. * Fix more xtro. * Another introspection fix. Co-authored-By: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply suggestions from code review Co-authored-by: Rolf Bjarne Kvinge <[email protected]> * Apply feedback * Please the typo guardians Co-authored-by: Frank A. Krueger <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

praeclarum added 2 commits September 6, 2019 19:31

[MPSCore] Update for Xcode 11 beta 1 to 7

9177adb

This also removes the hardcoded MetalPerformanceShaders library from Dlfcn as it conflicted with Libraries.g.cs

[MPSCore] Add MPSNDArray

19769c9

praeclarum requested review from dalexsoto and spouliot September 7, 2019 05:04

dalexsoto requested changes Sep 7, 2019

View reviewed changes

praeclarum and others added 3 commits September 7, 2019 07:52

Update src/metalperformanceshaders.cs

678e12b

Co-Authored-By: Alex Soto <[email protected]>

Update src/metalperformanceshaders.cs

c6342dd

Co-Authored-By: Alex Soto <[email protected]>

Update src/metalperformanceshaders.cs

abb6b1c

Co-Authored-By: Alex Soto <[email protected]>

Update src/metalperformanceshaders.cs

32fdad4

Co-Authored-By: Alex Soto <[email protected]>

rolfbjarne requested changes Sep 9, 2019

View reviewed changes

dalexsoto added the community Community contribution ❤ label Sep 10, 2019

praeclarum closed this Nov 15, 2019

praeclarum mentioned this pull request Nov 15, 2019

[MetalPerformanceShaders] Neural Networks Update to Xcode 11 #7461

Closed

dalexsoto mentioned this pull request Jun 12, 2020

[MetalPerformanceShaders] Neural Networks Update to Xcode 11 #8844

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MPSCore] Update for Xcode 11 beta 1 to 7 #6935

[MPSCore] Update for Xcode 11 beta 1 to 7 #6935

praeclarum commented Sep 7, 2019 •

edited

Loading

monojenkins commented Sep 7, 2019

Failed tests

dalexsoto left a comment

dalexsoto Sep 7, 2019

praeclarum Sep 7, 2019 •

edited

Loading

dalexsoto Sep 7, 2019

praeclarum Sep 7, 2019

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

Failed tests

rolfbjarne Sep 9, 2019

praeclarum Sep 9, 2019 •

edited

Loading

rolfbjarne Sep 9, 2019

rolfbjarne Sep 9, 2019

praeclarum Sep 9, 2019

rolfbjarne Sep 9, 2019

praeclarum commented Nov 11, 2019 •

edited

Loading

rolfbjarne commented Nov 12, 2019

praeclarum commented Nov 15, 2019

		@@ -0,0 +1,90 @@
		#if (XAMCORE_2_0 && !MONOMAC) && !XAMCORE_4_0

[MPSCore] Update for Xcode 11 beta 1 to 7 #6935

[MPSCore] Update for Xcode 11 beta 1 to 7 #6935

Conversation

praeclarum commented Sep 7, 2019 • edited Loading

monojenkins commented Sep 7, 2019

Test results

Failed tests

dalexsoto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praeclarum Sep 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

monojenkins commented Sep 7, 2019

Test results

Failed tests

Choose a reason for hiding this comment

praeclarum Sep 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praeclarum commented Nov 11, 2019 • edited Loading

rolfbjarne commented Nov 12, 2019

praeclarum commented Nov 15, 2019

praeclarum commented Sep 7, 2019 •

edited

Loading

praeclarum Sep 7, 2019 •

edited

Loading

praeclarum Sep 9, 2019 •

edited

Loading

praeclarum commented Nov 11, 2019 •

edited

Loading