up master #2
Merged
up master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing an intermittent repro of the `current` nodes of the sql editor and south pane refs returning null. Adding a safety check for both nodes.
…#6816) * Adding dropdown to DatasourceControl and ability to change datasource * Style fixes * Adding unit tests for datasource/get endpoint * Fixing issue with dropdown overflow and style changes * Fixing issues rebasing metadata button and fixing sort for datasource with no name
Update CHANGELOG.md
* Merge dataframe and column name mutation logic, add flag for disabling column aliases and add column name length checking * Remove custome mutate_label from oracle spec * Move hashing from mutate_label() to make_label_compatible() * Remove empty line * Make label mutating and truncating more robust * Rename variables and make proposed changes from review * Always execute labels_expected codepath * Fix linting error * Add comments and fix subquery errors * Refine column compatibility * Simplify label assignment * Add unit tests for BQ and Oracle * Linting
* Force quotes on non-expression time grains on postgres * Change to or semantics * Return lower case column name as unmutated * Add testcases for postgres time grains * Make expression MixedCase
This problem especially happens with pinot when you select two metrics with different aliases but same function. For example, effectively the sql like 'select type, count(*) as one, count(*) as two from bar group by type'. In such a case, pinot will return two columns, both named count_star. So when we try to do a df['count_star'], the result is a Dataframe and not a Series. This causes a KeyError in the get_df method. So we push the DB specific label mutation inside get_df before we do any other mutation.
* Add description field for columns * Add label for metrics
In superset-ui 0.8.0, we used bignumber.js to transform numbers in chartProps' payload from plain 64-bit floats to BigNumber instances. This causes a number of charts to render incorrectly when comparison functions in the rendering algorithms operate on BigNumber objects instead of floats. This PR uses the preTransformProps step in SuperChart to transform BigNumber instances back to floats so charts can render properly.
* Erase previously shown chart on error * Addressing comments * lint
* [js deps] fix dependencies vulnerabilities * Addressing comments * Fix bug with Mapbox default example
* Remove Cypress from package.json I'm building some Docker images these days and realizing just how big the Cypress package is. Looks like its ~500mb or so. I prefer adding it as needed only as opposed to having to play tricks as in `npm ci && rm node_modules/cypress` * Pin cypress version * Add script entry install-cypress * bump cypress and fix ts-jest warning
* Fix deck.gl viz * Fix more form data * Fix a few more places * Fix unit tests
* Allow for dynamic feature flags Giving more control over feature flags, allowing administrator to define custom logic around whether features are enabled for particular users / roles. The exposed function can be used for things like: * progressive rollout of features (1%, 5%, 50%, 100%) * experimentation * role-based feature affectation (only admins see a particular feature) * fix build * Addressing comments * Addressing @hughhh's comments
* Per database policies for slices * Show charts and dashboards based on DB perms as well * Revert indentation change * Fix reference * Fix pylint
|
up master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up master