Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js deps] fix dependencies vulnerabilities #6904

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

mistercrunch
Copy link
Member

found 68 vulnerabilities (63 low, 4 moderate, 1 high) in 41818 scanned packages
  run `npm audit fix` to fix 4 of them.
  64 vulnerabilities require semver-major dependency updates.

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #6904 into master will increase coverage by 0.87%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6904      +/-   ##
==========================================
+ Coverage   63.87%   64.74%   +0.87%     
==========================================
  Files         422      420       -2     
  Lines       20513    20340     -173     
  Branches     2230     2245      +15     
==========================================
+ Hits        13102    13170      +68     
+ Misses       7279     7037     -242     
- Partials      132      133       +1
Impacted Files Coverage Δ
superset/viz.py 71.6% <ø> (-0.05%) ⬇️
superset/assets/src/chart/Chart.jsx 15.15% <0%> (-2.09%) ⬇️
...rset/assets/src/explore/reducers/exploreReducer.js 35.71% <0%> (-12.57%) ⬇️
...erset/assets/src/dashboard/reducers/datasources.js 57.14% <0%> (-9.53%) ⬇️
...rc/dashboard/components/dnd/dragDroppableConfig.js 29.16% <0%> (-5.84%) ⬇️
...ts/src/dashboard/components/gridComponents/Tab.jsx 66.66% <0%> (-5.75%) ⬇️
...s/src/dashboard/components/gridComponents/Tabs.jsx 63.33% <0%> (-4.53%) ⬇️
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (-2.55%) ⬇️
superset/assets/src/chart/chartReducer.js 20.33% <0%> (-1.89%) ⬇️
.../src/dashboard/components/menu/WithPopoverMenu.jsx 76% <0%> (-1.56%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cac31d...a11f9be. Read the comment docs.

@kristw
Copy link
Contributor

kristw commented Feb 19, 2019

react-map-gl may have api changes. I had to do some updates for MapBox.
Have you verified with the deck.gl charts?

@mistercrunch
Copy link
Member Author

I had looked at the deck.gl demo examples dashboard to validate, they look fine.

Though it looks like MapBox doesn't work in master for now, seems unrelated to this though.

@kristw
Copy link
Contributor

kristw commented Feb 21, 2019

@mistercrunch MapBox has an issue particularly with the demo in master. Some lat or lon values has long tailed decimal point (due to float being float) and are serialized as json-bignumber and crashed the MapBox because it expects number, not object. Adding rounding to the query in viz.py probably helps.

@mistercrunch
Copy link
Member Author

@kristw I limited precision to 10 digits, the plan is probably to deprecate this visualization eventually

@mistercrunch mistercrunch requested review from xtinec and betodealmeida and removed request for xtinec February 26, 2019 00:28
@kristw
Copy link
Contributor

kristw commented Feb 26, 2019

Approved!

@mistercrunch mistercrunch merged commit 0ffccb7 into apache:master Feb 26, 2019
@mistercrunch mistercrunch deleted the bump_fix branch February 26, 2019 23:16
@muraiki
Copy link

muraiki commented Mar 5, 2019

Do you know what the high vulnerability package was? Should I be concerned about this as an end user running release 0.28.1?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants