Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-added deleted example file #6952

Merged
merged 1 commit into from
Feb 28, 2019
Merged

re-added deleted example file #6952

merged 1 commit into from
Feb 28, 2019

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Feb 27, 2019

The master is missing this file. Without it SS initialisation breaks
superset load_examples
therefore I re-added it by checking it out from a previous branch

@codecov-io
Copy link

Codecov Report

Merging #6952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6952   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files         421      421           
  Lines       20377    20377           
  Branches     2249     2249           
=======================================
  Hits        13196    13196           
  Misses       7048     7048           
  Partials      133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2ce75...009f817. Read the comment docs.

@mistercrunch
Copy link
Member

Looks like I am to blame for deleting this file. I have no idea how it might have happened though. Very confused. Anyhow, thank you for investigating and fixing this issue!

issue: #6904

@mistercrunch mistercrunch merged commit 6f82f97 into apache:master Feb 28, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants