Fix deck.gl form data

[betodealmeida]

Looks like we changed the schema of the form data payload, and this broke deck.gl visualizations. I fixed the visualizations, but it seems like there are other places where we still have the old format:

$ ggrep -ERsi '(formdata|fd|form_data)\.\w+_'
chart/chartAction.js:    const granularity = fd.time_grain_sqla || fd.granularity;
chart/chartAction.js:    fd.time_grain_sqla = granularity;
chart/chartAction.js:          has_extra_filters: formData.extra_filters && formData.extra_filters.length > 0,
chart/chartAction.js:          viz_type: formData.viz_type,
chart/chartAction.js:    const annotationLayers = formData.annotation_layers || [];
explore/store.js:  if (formData.y_axis_zero) {
explore/store.js:    formData.y_axis_bounds = [0, null];
explore/store.js:  const vizType = formData.viz_type || 'table';
explore/store.js:  const vizType = form_data.viz_type || 'table';
explore/exploreUtils.js:      viz_type: formData.viz_type,
explore/exploreUtils.js:  if (formData.slice_id) {
explore/exploreUtils.js:    search.form_data = safeStringify({ slice_id: formData.slice_id });
explore/components/ControlPanelsContainer.jsx:    return sectionsToRender(this.props.form_data.viz_type, this.props.datasource_type);
explore/components/ExploreChartHeader.jsx:              limit={formData.row_limit}
explore/components/ExploreViewContainer.jsx:    table_name: form_data.datasource_name,
explore/components/ExploreViewContainer.jsx:    vizType: form_data.viz_type,
explore/components/SaveModal.jsx:      vizType: props.form_data.viz_type,
dashboard/util/logging/childChartsDidLoad.js:    if (query.formData && query.formData.viz_type !== 'filter_box') {
dashboard/reducers/getInitialState.js:    if (['separator', 'markup'].indexOf(slice.form_data.viz_type) === -1) {
dashboard/reducers/getInitialState.js:        viz_type: slice.form_data.viz_type,
query/FormData.ts:  return 'granularity_sqla' in formData ? formData.granularity_sqla : formData.granularity;

@kristw should these be fixed as well? I'm not following the changes closely.

[codecov-io]

Codecov Report

Merging #6953 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #6953   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files         421      421           
  Lines       20377    20377           
  Branches     2249     2249           
=======================================
  Hits        13196    13196           
  Misses       7048     7048           
  Partials      133      133

Impacted Files	Coverage Δ
...erset/assets/src/visualizations/deckgl/factory.jsx	0% <ø> (ø)	⬆️
superset/assets/src/visualizations/deckgl/utils.js	94.33% <ø> (ø)	⬆️
...ets/src/visualizations/deckgl/layers/Grid/Grid.jsx	0% <0%> (ø)	⬆️
...c/visualizations/deckgl/layers/Scatter/Scatter.jsx	0% <0%> (ø)	⬆️
...t/assets/src/visualizations/deckgl/Multi/Multi.jsx	0% <0%> (ø)	⬆️
...ets/src/visualizations/deckgl/layers/Path/Path.jsx	0% <0%> (ø)	⬆️
...ssets/src/visualizations/deckgl/layers/Hex/Hex.jsx	0% <0%> (ø)	⬆️
...sualizations/deckgl/CategoricalDeckGLContainer.jsx	0% <0%> (ø)	⬆️
...assets/src/visualizations/deckgl/layers/common.jsx	30.43% <0%> (ø)	⬆️
...c/visualizations/deckgl/layers/Polygon/Polygon.jsx	0% <0%> (ø)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2ce75...2165c34. Read the comment docs.

[betodealmeida]

Fixing the unit test, the last commit broke it.

[kristw]

formData created via the controls (and the one stored in states, as well as sent to back-end in JSON payload) has snake_case fields. It is transformed when passing to the charts and all fields become camelCase

The change in this PR looks good to me.

[betodealmeida]

Thanks, @kristw! :)