Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6842: Refreshes all metadata and datasource #6944

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

prashant-shahi
Copy link
Contributor

Fixes for #6842. I, myself, encountered this issue when one of the druid clusters IPs was wrong, I was not able to refresh metadata or load up the list of latest datasources.

Added logic to not throw any exceptions but set a valid_cluster boolean to just flash a warning for the invalid or irresponsive clusters.

@codecov-io
Copy link

Codecov Report

Merging #6944 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6944      +/-   ##
==========================================
- Coverage   63.98%   63.97%   -0.01%     
==========================================
  Files         422      422              
  Lines       20537    20540       +3     
  Branches     2230     2230              
==========================================
  Hits        13141    13141              
- Misses       7264     7267       +3     
  Partials      132      132
Impacted Files Coverage Δ
superset/connectors/druid/views.py 66.21% <0%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0402b7...3003ae5. Read the comment docs.

@mistercrunch mistercrunch merged commit 3c2e3d7 into apache:master Feb 26, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants