Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.44.0 #2957

Merged
merged 90 commits into from
Jan 8, 2021
Merged

Release 1.44.0 #2957

merged 90 commits into from
Jan 8, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jan 5, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.44.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

mkevins and others added 30 commits November 26, 2020 17:46
@mkevins
Update gutenberg reference
a3b1abb
@ceyhun
Update jest config to use the new gb one
4f157d3
@ceyhun
Remove duplicate e2e test code
0fd4fc8
@ceyhun
Update gutenberg ref
93987a1
@ceyhun
Fix lint error
a09f0ba
@guarani
update submodule
5ed18db
@guarani
update submodule again
8ad4fb4
@guarani
Merge branch 'develop' into xpost_initial_implementation
31f749b
@guarani
Update the submodule yet again
eda7547
@cameronvoell
updated gutenberg ref
569984c
@guarani
Update submodule ref
f7db415
@guarani
add bundles and update gb submodule ref
1b9433c
@mchowning
Update gutenberg submodule ref
c2b98f2
@mchowning
Update bundles
3a05633
@ceyhun
Merge branch 'develop' into try/new-jest-config
e8e31f1
@ceyhun
Merge branch 'develop' into try/new-jest-config
b97f052
@dependabot
Bump jetpack from 829898d to 1bc2f22
c73b5c4 
Bumps [jetpack](https://github.com/Automattic/jetpack) from `829898d` to `1bc2f22`.
- [Release notes](https://github.com/Automattic/jetpack/releases)
- [Commits](Automattic/jetpack@829898d...1bc2f22)

Signed-off-by: dependabot[bot] <[email protected]>
@hypest
Merge pull request #2875 from wordpress-mobile/dependabot/submodules/…
3cbe9c2 
…jetpack-1bc2f22

Bump jetpack from `829898d` to `1bc2f22`
@mchowning
Update bundles
92e80fc
@mchowning
Update bundles
9c7854b
@mchowning
Update gutenberg submodule
1e8b2d9 
Only change is a fix to the snapshot tests
@mkevins
Update gutenberg reference
9c933aa
@mkevins
Merge branch 'develop' into try/image-block-link-picker
d803071
@mkevins
Update gutenberg reference
95c2380
@mkevins
Update lockfile
fef2c16
@mchowning
Update gutenberg submodule ref
b16cd9b
@mkevins
Update gutenberg reference
fdd285e
@mchowning
Update gutenberg ref
639d9b0
@mchowning
Update gutenberg submodule
0e265cf
Updated package lock
52621b4
@guarani guarani mentioned this pull request Jan 5, 2021
Merged
1 task
@guarani guarani requested a review from jhnstn January 5, 2021 03:02
@guarani guarani added this to the 1.44 (16.5) milestone Jan 5, 2021
@mkevins
Copy link
Contributor

mkevins commented Jan 5, 2021 •
edited
Loading

Sanity tests - iOS

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • ❓ Group - Nested block have proper margins values - TC006

I don't think it's a bug, but the test screenshot shows two appenders for the nested columns block, but the app doesn't show that. Maybe the test screenshot needs to be updated?

  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • 💥 Spacer block - Settings: Control spacer height using the text input - TC003

Any changes to the text input on the slider results in a crash.

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • ❌ Buttons block - Settings: Link rel - TC012

Link rel is not saved. Also, can't add spaces to the rel input.

  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
    test needs to be updated because link settings don't show unless there is a link
  • Buttons block - Settings: Synchronize with button options - TC013

Not related:
Link picker only shows same 3 results - known issue.

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

@geriux geriux mentioned this pull request Jan 5, 2021
Closed
@geriux
Copy link
Contributor

geriux commented Jan 5, 2021 •
edited
Loading

Sanity tests - Android

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@guarani guarani marked this pull request as ready for review January 5, 2021 17:21
@guarani
Add Spacer and Button block fixes
a3e8635 
PRs #27987 (Spacer fix) and #27997 (Button fix)
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 5, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani
Copy link
Contributor Author

guarani commented Jan 5, 2021 •
edited
Loading

Performed writing flow tests using build 39906 on iPhone 11, iOS 14.2.

Writing Flow checklist

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

Issues

TC001 - Paste formatted text copied from website

I ran into WordPress/gutenberg#28004 which is not a new regression.

TC001 - Bold, Italic, strikethrough buttons

I ran into the existing #2154 (not a blocker).

@guarani
Copy link
Contributor Author

guarani commented Jan 6, 2021 •
edited
Loading

Performed writing flow tests using build 39948 on iPhone 11, iOS 14.2.

(This additional testing was needed because I forgot to include a new bundle to the Gutenberg Mobile PR. On Android the bundle is not needed since it generates its own bundle.)

Writing Flow checklist

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

Issues

TC001 - Paste formatted text copied from website

I ran into WordPress/gutenberg#28004 which is not a new regression.

TC001 - Bold, Italic, strikethrough buttons

I ran into the existing #2154 (not a blocker).

@jhnstn
Copy link
Member

jhnstn commented Jan 6, 2021

Performed writing flow tests using build 89176 on Google Pixel 5, Android 11.

Writing Flow checklist

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • ❌ - Pullquote:

      tags per non-wrapping "line"

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace

Splitting and merging

  • TC001 - Merge after writing
  • [] TC002 - Merge after selection -> known issue Deleting Entire Word Prevents Merging Blocks #2375
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

Issues

TC001 - Multiline components

Ran into this issue while testing the PullQuote. It's not a regression so non blocking.

I also ran into these other existing non blocking issues: #2498, #27690

@guarani guarani mentioned this pull request Jan 7, 2021
Open
@guarani
Copy link
Contributor Author

guarani commented Jan 8, 2021 •
edited
Loading

Tested Android build 89534 the changes and bug fixes listed above:

@guarani
Copy link
Contributor Author

guarani commented Jan 8, 2021 •
edited
Loading

Tested WPiOS build 40102 the changes and bug fixes listed above:

Issues

I ran into an issue where Xposts didn't load. The reason is that some sites returned by the Xpost endpoint have URLs that are malformed which break parsing in the apps. Issue created here: #2982

@guarani guarani requested a review from antonis January 8, 2021 14:43
antonis
antonis approved these changes Jan 8, 2021
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @guarani 👍

@guarani
Copy link
Contributor Author

guarani commented Jan 8, 2021

I ran into an issue where Xposts didn't load. The reason is that some sites returned by the Xpost endpoint have URLs that are malformed which break parsing in the apps. Issue created here: #2982

I'm marking this done and moving on with the release because the fix for #2982 does not depend on the release, PR up here: wordpress-mobile/WordPress-iOS#15610

@guarani guarani merged commit 35b0436 into trunk Jan 8, 2021
@guarani guarani deleted the release/1.44.0 branch January 8, 2021 18:00
This was referenced Jan 9, 2021
Closed
Merged
@mchowning mchowning mentioned this pull request Jan 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.44 (16.5)
Development

Successfully merging this pull request may close these issues.