Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor doesn't handle scroll position correctly when keyboard focus changes #28004

Closed
guarani opened this issue Jan 5, 2021 · 3 comments
Closed
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Comments

@guarani
Copy link
Contributor

guarani commented Jan 5, 2021

Describe the bug

On a long post, if a block has keyboard focus while off-screen, and I tap text in an on-screen block, instead of just showing the keyboard and allowing me to type into the on-screen block, the editor scrolls all the way down to the off-screen block that previously had keyboard focus.

To Reproduce

  1. Open a long post (two or more screens of content)
  2. Put keyboard focus (not block focus) on a block near the bottom of the editor content
  3. Manually scroll to the top of the post
  4. Tap a block that allows keyboard input and notice that instead of simply showing the keyboard, the editor scrolls down to the block whose input lost focus

Expected behavior
The editor should maintain the scroll position if an already visible input gains keyboard focus.

Screenshots

Screen recording showing editor jumping when changing keyboard focus

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 14
  • Version 1.43.0 and 1.44.0 releases of Gutenberg Mobile
@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 5, 2021
@mchowning
Copy link
Contributor

Thanks for reporting this @guarani . I tried this on Android, and it appears this is only an issue on iOS. Just let me know if you think I'm wrong about that.

@dcalhoun
Copy link
Member

@guarani I arrived here from wordpress-mobile/gutenberg-mobile#3085. I am no longer able to reproduce this issue on WordPress iOS 16.7. Are you still able to re-produce this issue or should we close this? I'm wondering if it this was fixed by #28352.

@guarani
Copy link
Contributor Author

guarani commented Feb 26, 2021

@guarani I arrived here from wordpress-mobile/gutenberg-mobile#3085. I am no longer able to reproduce this issue on WordPress iOS 16.7. Are you still able to re-produce this issue or should we close this? I'm wondering if it this was fixed by #28352.

Thanks for checking! Yep, I can't reproduce this either on WPiOS 16.7.1 or WPAndroid 16.7 (although I don't think it was ever an Android issue) – closing this.

@guarani guarani closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

No branches or pull requests

3 participants