Add support for xpost suggestions on mobile #26211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
mchowning
force-pushed
the
rnmobile/xpost_initial_implementation
branch
from
1e6d21d to
0ae4415
Compare
2 tasks
mchowning
force-pushed
the
rnmobile/xpost_initial_implementation
branch
3 times, most recently
from
4957240 to
524311b
Compare
Update it to the new callback function
This is limited to Android at this time
guarani
force-pushed
the
rnmobile/xpost_initial_implementation
branch
from
524311b to
cf73fbd
Compare
Long-pressing the @-mentions toolbar button will now let the user add an Xpost or an @-mention
guarani
reviewed
Dec 3, 2020
3 tasks
The addition of the xposts modal in e730f2e broke these snapshot tests.
Because using Toolbar with a label prop is deprecated: https://github.com/WordPress/gutenberg/blob/af768dc98c625e33de8023084c6a5c198c52f8ef/packages/components/src/toolbar/index.js#L30-L34
packages/react-native-editor/android/app/src/main/java/com/gutenberg/MainApplication.java
Show resolved
Hide resolved
packages/react-native-editor/ios/GutenbergDemo/GutenbergViewController.swift
Show resolved
Hide resolved
|
👋 @jhnstn! If you have a chance, I would appreciate it if you could take a look at the js code in this PR. |
cameronvoell
approved these changes
Dec 18, 2020
|
👋 @mchowning and @guarani , please add some testing steps (here or in the gutenberg-mobile PR), thanks! |
3 tasks
guarani
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Working great from my perspective! Tested demo apps on both platforms, I think this is ready to merge.
Thanks @mchowning!
This was referenced Dec 29, 2020
jhnstn
reviewed
Jan 14, 2021
| icon: plus, | ||
| }, | ||
| ]; | ||
| return allOptions.filter( ( op ) => op.supported ); |
There was a problem hiding this comment.
I personally prefer using functional flows like using filter here but I think it might be more familiar to build allOptions with conditionals (i.e.) :
const allOptions = [];
if ( areMentionsSupported ) {
allOptions.push({<option object>})
}
if ( areXPostsSupported ) {
allOptions.push({<option object>})
}
return allOptions;
jhnstn
reviewed
Jan 14, 2021
| const { keyCode } = event; | ||
| const triggeredOption = this.suggestionOptions().find( ( option ) => { |
There was a problem hiding this comment.
Can the return from this.suggestionOptions be memorized to a class property so doesn't have to be called on every key code event?
|
@mchowning looks good! I left a few comments but nothing blocking. Edit: apologies for the late review, I hadn't updated my notifications on Github when I got the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding xpost handling for mobile
Related:
How has this been tested?
In the demo app:
@toolbar button and choose Crosspost to insert a dummy Xpost.@toolbar button and choose Mention to check that a mention is still inserted@button to make sure that a mention is still insertedScreenshots
Types of changes
Checklist: