Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons block - Link rel setting not working correctly #27996

Closed
geriux opened this issue Jan 5, 2021 · 0 comments · Fixed by #27997
Closed

Buttons block - Link rel setting not working correctly #27996

geriux opened this issue Jan 5, 2021 · 0 comments · Fixed by #27997
Assignees
@geriux
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@geriux
Copy link
Member

geriux commented Jan 5, 2021

Describe the bug
While doing some sanity tests for the 1.44.0 release an issue was reported for the Buttons block - Settings: Link rel test case. While setting a link rel value and closing the bottom sheet, it doesn't get saved.

To reproduce
Steps to reproduce the behavior:

  1. Add a Buttons block
  2. Set a link using the toolbar link setting
  3. Set a link
  4. Set a link rel value
  5. Close the bottom sheet
  6. Open the link setting again
  7. The link rel value was not saved

Expected behavior
The link rel value should be saved when closing the bottom sheet

Screenshots

Editor version (please complete the following information):
Current release 1.44.0

Smartphone (please complete the following information):

  • Device iPhone / Android
@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 5, 2021
@geriux geriux self-assigned this Jan 5, 2021
@geriux geriux added the [Type] Bug An existing feature does not function as intended label Jan 5, 2021
@geriux geriux mentioned this issue Jan 5, 2021
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 5, 2021
@geriux geriux mentioned this issue Jan 7, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geriux geriux

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Mobile] - Link settings - Fix updating settings when closing the bottom sheet WordPress/gutenberg
1 participant
@geriux