-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image size and rounding options missing on images in starter page templates #2950
Comments
Pinging you here @chipsnyder for your insights. |
FWIW, here's what I noticed from my testing:
Tested on:
|
Thanks @guarani and @hypest for the research here. It seems to me we should approach this from two sides.
@enejb I'm sure how much you have on your plate right now, but can you take a look at this? If needed we can split this into two efforts. |
Looking into this now. |
Just that to get this into the 16.5 apps release, the fix for this will be merged in after the 1.44.0 release is cut today which is fine (preferably early in the week). However, if this was high priority and needed to make it to the 16.4 apps release, that would require a editor betafix. Could you share @chipsnyder in which release you think this will need to land in? |
I think I understand the issue better now. The only difference between the image that comes with the template and the once that gets instead is that the one in with the template doesn't live with in the media library. The html stucture is the same
The reason why the images are not displaying the rounded and the size attributes is because the images don't currently live on the main site but are just hot linked. So the backend solution that we should look into is updating the URLs and IDs of the media in the content as well as Importing the media. Which can be a bit tricky but would solve a bunch of other issues as well. |
Thanks @enejb, for sharing your findings. It sounds like the defaults are already there then and the path forward is that backend fix you mentioned @enejb.
@guarani I think we can move forward with the editor release and we'll explore the backend fix. |
Thanks for checking @enejb and @chipsnyder! |
There does seem to be some larger considerations that need to be tackled regarding the server-side fix. Enej was able to get a client-side fix in place WordPress/gutenberg#28006 @guarani what are your thoughts on including this in the release? (Note this is more a new feature than a regression technically speaking but probably more of a bug from the user's perspective. |
Image size still has some dependencies with Hot-linked images to where those menu options aren't appearing. However, we are now consistent with the web experience. |
Describe the bug
Image block is missing Size and Default/Rounded options on images found in Starter Page Templates.
To Reproduce
Expected behavior
Just like any other image, the Size and Default/Rounded options should be present
Screenshots
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: