Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Design Screen Improvements #18740

Merged
merged 125 commits into from
Jun 3, 2022
Merged

Site Design Screen Improvements #18740

merged 125 commits into from
Jun 3, 2022

Conversation

antonis
Copy link

@antonis antonis commented May 26, 2022 •
edited
Loading

Description

This PR implements the Site Design Screen Improvements (internal ref: pbArwn-4jE-p2)

To test

Follow the test plan at pc8HXX-lA-p2

Regression Notes

  1. Potential unintended areas of impact
    Page Layout Picker

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    Added SiteDesignSectionLoaderTests and modified SiteDesignTests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

twstokes and others added 30 commits April 26, 2022 16:53
@twstokes
Remove preview mode selector from the nav bar.
a1937ad
@twstokes
Remove Tracks helper function for the thumbnail preview mode.
02f519e
@twstokes
Point to WordPressShared pod branch.
d920a0c
@twstokes
Remove Tracks event.
9e3248f
@twstokes
Enforce mobile thumbnails and prevent changing them with the device m…
1e02f9b 
…ode picker for previews.
@twstokes
Override the getter and setter for the superclass property.
af51a87
@twstokes
Test that the preview device can't be changed on design screen.
2db87b6
@twstokes
Add test for preview view.
a68c8c4
@twstokes
Point to feature branch for iOS Shared pod.
c7f1cba
@twstokes
Store the selected preview device for the Preview view.
baae1a1
@twstokes
Remove test for Preview view.
19b1dcc
@twstokes
Tweak access control for Preview view device.
07e45e5
@twstokes
Use device default for initial Preview device size.
0620afb
@twstokes
Reword title.
52752f9
@twstokes
Hide prompt view and remove text.
a3dc8f7
@twstokes
Make the prompt text optional and hide the view when it's nil.
3e9f2d5
@ovitrif
Merge pull request #18474 from wordpress-mobile/task/site-design-main…
49e6b1b 
…-screen-ui

[Site Design Revamp] Update title text and remove subtext
@twstokes
Merge pull request #18455 from wordpress-mobile/task/site-design-remo…
2830846 
…ve-preview-mode-picker

[Site Design Revamp] Remove preview mode selector from nav bar
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
0dc8332 
…revamp
@twstokes
Remove UIPopoverPresentationControllerDelegate conformance.
b707b9c
@twstokes
Add options to cells to disable decorations upon selection.
2240c7b
@twstokes
Remove action button tests now that we don't show action buttons.
8ccca1f
@twstokes
Subclass CollapsableHeaderViewController directly to remote filtering…
3870555 
… and have more control over collection view cells.
@twstokes
Add extension to Jetpack target.
abed465
@twstokes
Make selectedPreviewDevice constant since we're no longer subclassing.
d37f4e4
@twstokes
Only toggle the checkmark for CollapsableHeaderCollectionViewCells an…
8b0e649 
…d remove the selection when dismissing the preview view.
@twstokes
Remove unnecessary test now that we're using a constant.
d17c426
@twstokes
Merge pull request #18506 from wordpress-mobile/task/site-design-remo…
48ac178 
…ve-buttons-filtering

[Site Design Revamp] Main View - remove filtering and action buttons
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
0236691 
…revamp
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
56b2ea4 
…revamp
twstokes and others added 14 commits May 27, 2022 10:45
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
d0dbe10 
…revamp
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
a8b9a1e 
…revamp
@twstokes
Add release note for Site Design Screen Improvements project.
922a7b8
@twstokes
Merge pull request #18785 from wordpress-mobile/task/site-design-reva…
b83a832 
…mp-release-notes

[Site Design Revamp] Add release note
@twstokes
Use the Footnote size for the caption.
27abf55
@twstokes
Tighten up caption spacing.
fa59efa
@twstokes
Deselect the thumbnail cell after the preview is presented.
8cdb09e
@twstokes
Make the Site Design screen header solid.
727e157
Merge pull request #18786 from wordpress-mobile/task/site-design-capt…
834a046 
…ion-font

[Site Design Revamp] Update recommended designs caption font
Merge pull request #18787 from wordpress-mobile/task/site-design-remo…
b84397d 
…ve-selection-border-on-dismiss

[Site Design Revamp] Remove selection border on dismissal of preview
Merge pull request #18789 from wordpress-mobile/task/site-design-reva…
633ea5e 
…mp-solid-header

[Site Design Revamp] Make the Site Design screen header solid
@twstokes
Reset the scroll position every time data changes.
3f6ee94
@twstokes
Merge remote-tracking branch 'origin/trunk' into feature/site-design-…
8c9f73c 
…revamp
Merge pull request #18795 from wordpress-mobile/task/site-design-reva…
30d853a 
…mp-reset-table

[Site Design Revamp] Reset the scroll position every time site designs are shown
@antonis antonis requested a review from a team June 2, 2022 09:59
@antonis antonis marked this pull request as ready for review June 2, 2022 09:59
@twstokes twstokes mentioned this pull request Jun 2, 2022
Merged
2 tasks
@twstokes
Copy link
Contributor

twstokes commented Jun 2, 2022

Dependency PRs:

twstokes
twstokes approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 I did a smoke test on an iPhone 13 and everything looked good.

@antonis antonis merged commit 0ad4c83 into trunk Jun 3, 2022
@antonis antonis deleted the feature/site-design-revamp branch June 3, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
Site Creation [Type] Enhancement
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
5 participants
@antonis @wpmobilebot @twstokes @ovitrif @Gio2018