-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Design Revamp] Make the Site Design screen header solid #18789
[Site Design Revamp] Make the Site Design screen header solid #18789
Conversation
Generated by 🚫 dangerJS |
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the before photo looks like the after photo don't worry - you probably have normal human vision.
😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being honest I couldn't spot the difference but I validated that the generated build worked on an iPhone SE 2020 (iOS 14.7.1). The code change also look consistent to me 🎉
Thank you for wrangling this @twstokes 🙇
That is indeed very subtle 😄 . |
Fixes tweak 4 of #18677
This PR matches the top header bar and the background colors of the Site Design screen. If the before photo looks like the after photo don't worry - you probably have normal human vision.
Testing
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.