Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Design Revamp] Make the Site Design screen header solid #18789

Merged

Conversation

twstokes
Copy link
Contributor

Fixes tweak 4 of #18677

This PR matches the top header bar and the background colors of the Site Design screen. If the before photo looks like the after photo don't worry - you probably have normal human vision.

Before After Light After Dark
Simulator Screen Shot - iPhone 13 - 2022-05-31 at 15 27 10 Simulator Screen Shot - iPhone 13 - 2022-05-31 at 15 23 55 Simulator Screen Shot - iPhone 13 - 2022-05-31 at 15 24 20

Testing

  1. Start the Site Creation flow
  2. Navigate to the Site Design screen
  3. Observe the background color of the header and the rest of the view

Regression Notes

  1. Potential unintended areas of impact
  • None
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Visually inspected the difference in light and dark modes.
  1. What automated tests I added (or what prevented me from doing so)
  • None, as these are visual changes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes added this to the 20.1 milestone May 31, 2022
@twstokes twstokes requested review from kyleaparker and a team May 31, 2022 19:34
@twstokes twstokes self-assigned this May 31, 2022
@peril-wordpress-mobile
Copy link

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@twstokes twstokes changed the title [Site Design Revamp] Make the Site Design screen header solid. [Site Design Revamp] Make the Site Design screen header solid May 31, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18789-727e157 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18789-727e157 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link

@kyleaparker kyleaparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the before photo looks like the after photo don't worry - you probably have normal human vision.

😆

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being honest I couldn't spot the difference but I validated that the generated build worked on an iPhone SE 2020 (iOS 14.7.1). The code change also look consistent to me 🎉
Thank you for wrangling this @twstokes 🙇

@antonis antonis merged commit 633ea5e into feature/site-design-revamp Jun 1, 2022
@antonis antonis deleted the task/site-design-revamp-solid-header branch June 1, 2022 13:19
@mkevins
Copy link
Contributor

mkevins commented Jun 2, 2022

before photo looks like the after photo

That is indeed very subtle 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants