Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Design Revamp] Update recommended designs caption font #18786

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

twstokes
Copy link
Contributor

Fixes #18674

  • Reduces the font size from Subhead / Semibold to Footnote / Regular [HIG typography]
  • Reduces the margin between the title and the caption
Before After
Simulator Screen Shot - iPhone 13 - 2022-05-31 at 13 40 20 Simulator Screen Shot - iPhone 13 - 2022-05-31 at 14 00 04

Testing

  1. Start the Site Creation flow
  2. Navigate to the Site Design picker screen
  3. Observe the font size of the caption for the recommended designs section

Regression Notes

  1. Potential unintended areas of impact
  • None
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • None
  1. What automated tests I added (or what prevented me from doing so)
  • This was purely visual.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes self-assigned this May 31, 2022
@twstokes twstokes requested review from a team and kyleaparker May 31, 2022 18:05
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18786-fa59efa on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18786-fa59efa on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @twstokes 👍
I've tested the CI build on an iPhone SE 2020 (iOS 14.7.1) and it works as expected. The code changes also LGTM 🎉

@antonis antonis merged commit 834a046 into feature/site-design-revamp Jun 1, 2022
@antonis antonis deleted the task/site-design-caption-font branch June 1, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants