Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site Design Revamp] Add caption above recommended section label #18674

Closed
twstokes opened this issue May 20, 2022 · 2 comments
Closed

[Site Design Revamp] Add caption above recommended section label #18674

twstokes opened this issue May 20, 2022 · 2 comments
Assignees
@Gio2018
Labels
Site Creation [Type] Task

Comments

@twstokes
Copy link
Contributor

twstokes commented May 20, 2022 •
edited
Loading

Description

Add the caption "PICKED FOR YOU" above the recommended section label.

Attributes:

  • 13pt
  • All caps
  • Light gray

PRs should target the feature/site-design-revamp feature branch.
@twstokes twstokes mentioned this issue May 20, 2022
Merged
4 tasks
@Gio2018 Gio2018 self-assigned this May 23, 2022
@Gio2018 Gio2018 mentioned this issue May 23, 2022
Merged
4 tasks
@twstokes twstokes reopened this May 31, 2022
@twstokes
Copy link
Contributor Author

twstokes commented May 31, 2022 •
edited
Loading

Per @kyleaparker, this should match the typography used on the My Site view:

Inspecting BlogDetailsSectionHeaderView shows that this is the "Footnote" size:

image

@twstokes twstokes mentioned this issue May 31, 2022
Merged
4 tasks
@antonis
Copy link

antonis commented Jun 1, 2022

Fixed with #18786

@antonis antonis closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gio2018 Gio2018

Labels
Site Creation [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antonis @twstokes @Gio2018