-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Design Revamp - Add Caption to Recommended Section #18710
Site Design Revamp - Add Caption to Recommended Section #18710
Conversation
…l and related configuration methods
…caption in tableView(_:cellForRowAt:)
…mmended section * also reorganized strings in enum TextContent
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @Gio2018! 🚀 I tested different accessibility sizes as well as VoiceOver.
In the Figma designs by @kyleaparker it looks like the font size is defined as 13px
with a 590 weight. Using .subheadline
puts the font at 15pt
(px) and I also see we're defining .semibold
for the weight.
.caption1
is defined as 12px
in the HIG with regular weight. .caption1
with .semibold
is visually closest to me, but I wanted to get your thoughts.
Designs |
---|
It's best to view these screenshots fullscreen to get a sense of scale.
Subheadline | Caption 1 Regular | Caption 1 Semibold |
---|---|---|
...s/ViewRelated/Site Creation/Design Selection/SiteDesignContentCollectionViewController.swift
Outdated
Show resolved
Hide resolved
Thanks @twstokes !
I thought about that, but it looks a bit unreadable. Thoughts @kyleaparker ? |
...s/ViewRelated/Site Creation/Design Selection/SiteDesignContentCollectionViewController.swift
Outdated
Show resolved
Hide resolved
…read the caption from the section property
…_:cellForRowAt:), remove unnecessary call to set the cell caption
I think subheadline is probably the best here but we may need to add some margin underneath |
Sounds good! We have a UI tweaks issue that I'll add this note to. 👍 |
Fixes #18674
This PR adds a caption to the recommended section in the Site Design Picker
To test:
Regression Notes
Potential unintended areas of impact
Low - Page design picker uses part of the same code
What I did to test those areas of impact (or what existing automated tests I relied on)
test that the page design picker was not impacted
What automated tests I added (or what prevented me from doing so)
none
PR submission checklist:
RELEASE-NOTES.txt
if necessary.