Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge feature branch for Site Design Screen Improvements project #516

Merged
merged 8 commits into from
Jun 3, 2022
Merged

Merge feature branch for Site Design Screen Improvements project #516

merged 8 commits into from
Jun 3, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Jun 2, 2022

Description

Included PRs:

Testing Details

The WPiOS feature branch is pointed to 88d45f4.

  1. Compile the WPiOS feature branch
  2. Navigate to the Site Design screen
  3. Confirm that site designs are loaded
  • Please check here if your pull request includes additional test coverage.
  • I have considered updating the version in the .podspec file.

@twstokes twstokes added the enhancement New feature or request label Jun 2, 2022
@twstokes twstokes requested review from antonis and mkevins June 2, 2022 15:16
@twstokes twstokes self-assigned this Jun 2, 2022
@twstokes twstokes mentioned this pull request Jun 2, 2022
Merged
4 tasks
mkevins
mkevins approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on an iPhone 11, and it is working as expected. 👍 Nice work Tanner 🎉

@mkevins
Copy link
Contributor

mkevins commented Jun 3, 2022

Also, I double checked that the reference from the related (main) WordPress-iOS PR is correct. Thought it points one commit earlier, the latest commit is just the version bump, and it will be updated anyway when merged, so LGTM!

@twstokes twstokes merged commit 7fa1614 into trunk Jun 3, 2022
@twstokes twstokes deleted the feature/site-design-revamp branch June 3, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@antonis antonis Awaiting requested review from antonis

Assignees

@twstokes twstokes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twstokes @mkevins