Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Design Revamp] Add optional group array for remote site designs #507

Merged
merged 2 commits into from
May 19, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented May 17, 2022

Description

Related:

This PR adds the ability to decode the optional group array parameter from remote designs served by the themes endpoint. It is backwards compatible in the event that the API doesn't serve the group parameter.

Testing Details

Use wordpress-mobile/WordPress-iOS#18657 for testing.

  • Please check here if your pull request includes additional test coverage.
  • I have considered updating the version in the .podspec file.

@twstokes twstokes force-pushed the task/remote-design-groups branch from 0472bd8 to 3a6aa8c Compare May 19, 2022 01:36
@twstokes twstokes force-pushed the task/remote-design-groups branch from 3a6aa8c to 92e47d9 Compare May 19, 2022 15:02
@twstokes twstokes changed the base branch from trunk to feature/site-design-revamp May 19, 2022 16:13
@twstokes twstokes changed the title Add optional groups array for remote site designs. [Site Design Revamp] Add optional group array for remote site designs May 19, 2022
@twstokes twstokes added the enhancement New feature or request label May 19, 2022
@twstokes twstokes self-assigned this May 19, 2022
@twstokes twstokes marked this pull request as ready for review May 19, 2022 16:23
@twstokes twstokes requested a review from Gio2018 May 19, 2022 16:24
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @twstokes !
Let's just make sure, before we cut the release, that this won't break anything in trunk. It shouldn't, but some extra caution is probably better since we are working on a feature branch.

@twstokes
Copy link
Contributor Author

This looks good to me @twstokes ! Let's just make sure, before we cut the release, that this won't break anything in trunk. It shouldn't, but some extra caution is probably better since we are working on a feature branch.

Sounds good @Gio2018. 👍 I was thinking we'll do another PR pointed to trunk when we're ready to merge the feature branch, so we can take that opportunity to double-check things.

@twstokes twstokes merged commit e371ff3 into feature/site-design-revamp May 19, 2022
@twstokes twstokes deleted the task/remote-design-groups branch May 19, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants