Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Design Revamp] Update title text and remove subtext #18474

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Apr 28, 2022

Fixes items B and C in #18433.

This PR:

  • Renames the title from "Choose a design" to "Choose a theme"
  • Removes the subtext from the view (it was decided to not repurpose this text for a11y)
Before After
Simulator Screen Shot - iPhone 13 - 2022-04-28 at 15 47 24 image

To test:

  1. Start the Site Creation flow and navigate to the Site Design screen
  2. Expect that the title is "Choose a theme"
  3. Expect there to be no subtext (e.g. "Pick your favorite homepage layout...")

⚠️ On screen rotation there is a known issue that wasn't introduced with this PR.

Regression Notes

  1. Potential unintended areas of impact

    • Visual impacts of views that rely on the Collapsable Header View
      • Page layout view (when creating a new page)
      • Site Intent view (when creating a site)
      • Domain selection view (when creating a site, if not prompted to enter the site name)
      • Blogging prompts feature introduction view (this appears to be disabled behind a Feature Flag)
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Visiting the views above and testing scrolling + orientation changes.
  3. What automated tests I added (or what prevented me from doing so)

    • These changes are primarily visual

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18474-3e9f2d5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18474-3e9f2d5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes marked this pull request as ready for review April 28, 2022 20:22
@twstokes twstokes requested a review from a team April 28, 2022 20:22
@twstokes twstokes changed the title Task/site design main screen UI [Site Design Revamp] Update title text and remove subtext Apr 28, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@twstokes twstokes added this to the 19.9 milestone Apr 28, 2022
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and there's no regression.

Great work @twstokes :shipit: 🚀

@ovitrif ovitrif merged commit 49e6b1b into task/site-design-remove-preview-mode-picker Apr 29, 2022
@ovitrif ovitrif deleted the task/site-design-main-screen-ui branch April 29, 2022 09:36
@twstokes
Copy link
Contributor Author

twstokes commented Apr 29, 2022

Thank you @ovitrif!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants