Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Facebook publicize option #8026

Closed
wants to merge 154 commits into from
Closed

Conversation

kwonye
Copy link
Contributor

@kwonye kwonye commented Jul 11, 2018

Fixes #7591

To test:

Open the publicize page and make sure the Facebook row isn't shown.

@kwonye kwonye added this to the 10.5 milestone Jul 11, 2018
@kwonye kwonye added the Sharing label Jul 11, 2018
@loremattei loremattei modified the milestones: 10.5 ❄️, 10.6 Jul 16, 2018
@loremattei
Copy link
Contributor

Hey! I'm moving the milestone to 10.6 because 10.5 has been cut. Please, feel free to move it back to 10.5 if it has to land there: update it to target the release branch and ping me to update the build!

oguzkocer and others added 23 commits July 24, 2018 13:36
…empty-states

Issue/7996 actionable empty states (Part 2)
…ilogue

Replace Volley with Glide - login epilogue
…ites-you-may-like

Replace Volley with Glide - ReaderBlogFragment
…lete-warning

Update testCompile to testImplementation
…ag-header

Replace Volley with Glide in custom reader tag header view
Replaces Volley with Glide in ReaderPostDetail section
Limit the max length of support name to 50 for Zendesk
…omment-header

Replace Volley with Glide in the Reader Comment header view
…length

Add max length checks for translated metadata strings
warning about the end of publicize on August 1
@kwonye kwonye changed the base branch from develop to release/10.5 July 29, 2018 21:33
@kwonye
Copy link
Contributor Author

kwonye commented Jul 29, 2018

Closing and rebasing off 10.5 without a merge from develop

@kwonye kwonye closed this Jul 29, 2018
@kwonye kwonye modified the milestones: 10.6, 10.5 ❄️ Jul 29, 2018
@jkmassel jkmassel deleted the hide-facebook-publicize branch October 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.