Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces Volley with Glide in ReaderPostDetail section #8075

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Replaces Volley with Glide in ReaderPostDetail section #8075

merged 1 commit into from
Jul 25, 2018

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jul 23, 2018 •
edited
Loading

Fixes #8074

Replaces Volley with Glide in the Reader Post Detail.

  • Avatar/Blavatar in the header is displayed with Glide - no change from the user perspective
  • Liked by section avatars are displayed with glide - no change from the user perspective
  • More in XYZ blog/More on WordPress.com avatar/blavatar/feature images are displayed with Glide - feature images can theoretically contain animated gif, however I'm not sure how to test it, since this section is picked 'randomly'. Nevertheless the ImageManager.load(..) method is used in many other places in the app and it loads GIF images correctly, so I'd just assume it'll work here as well.

The content of the post is displayed in a default WebView, so Glide is not used for images in the content area.

To test:

  1. Open detail of a post in Reader
  2. Make sure all the images mentioned above are correctly loaded.

Note: Can one of you review it please. Thanks!

@malinajirka malinajirka requested a review from nbradbury July 23, 2018 07:12
@malinajirka malinajirka added this to the 10.6 milestone Jul 23, 2018
@mzorz mzorz self-assigned this Jul 25, 2018
mzorz
mzorz approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM :shipit:

@mzorz mzorz merged commit 397ad97 into develop Jul 25, 2018
@mzorz mzorz deleted the feature/glide-post-detail branch July 25, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@nbradbury nbradbury Awaiting requested review from nbradbury

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@aforcier aforcier Awaiting requested review from aforcier

Assignees

@mzorz mzorz

Labels
Reader
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@malinajirka @mzorz