Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Volley with Glide in custom reader tag header view #8083

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Replace Volley with Glide in custom reader tag header view #8083

merged 1 commit into from
Jul 25, 2018

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jul 23, 2018 •
edited
Loading

Fixes #8082

Replaces Volley with Glide in the Custom Reader tag header view. Nothing should change from the user perspective.

To test:

  1. Go to Reader
  2. Click on the gear icon
  3. Add a custom tag (for example android)
  4. Go back to reader
  5. Select the custom tag from the drop down
  6. Make sure the image in the header is displayed

Note: Can one of you review it please. Thanks!

@malinajirka malinajirka added this to the 10.6 milestone Jul 23, 2018
@mzorz mzorz self-assigned this Jul 25, 2018
mzorz
mzorz approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected. LGTM :shipit:

@mzorz mzorz merged commit 59f8219 into develop Jul 25, 2018
@mzorz mzorz deleted the feature/glide-reader-tag-header branch July 25, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@nbradbury nbradbury Awaiting requested review from nbradbury

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@aforcier aforcier Awaiting requested review from aforcier

Assignees

@mzorz mzorz

Labels
None yet
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@malinajirka @mzorz