Facebook Publicize disable selection of profiles #8115

kwonye · 2018-07-30T03:01:24Z

We're no longer allowing users to add their profiles to publicize. Also, this adds pages to the selection list where people can connect to.

To test:

Add a facebook account with a page. Only the page will be shown in the selection dialog. No profiles.
Add a facebook account with no pages. It will error out.
See the facebook detail item and notice the new user message about the changes August 1st.

@loremattei we're going to make a 10.5.1 to release this by August 1. Feel free to ship 10.5 without this tomorrow, thanks!

warning about the end of publicize on August 1

This reverts commit 3834d18.

mzorz

Thanks for this @kwonye , I left a comment and a question, will start testing now

mzorz · 2018-07-30T12:41:17Z

...ess/src/main/java/org/wordpress/android/ui/publicize/PublicizeAccountChooserListAdapter.java

+    private String getName(PublicizeConnection connection) {
+        String name = connection.getExternalDisplayName();
+
+        if (name.isEmpty()) {


Let's use TextUtils.isEmpty(name) here so we also have null as a possibility

mzorz · 2018-07-30T12:41:36Z

WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeActions.java

                }
            }

-            return totalAccounts > 0;
+            if (PublicizeTable.onlyExternalConnections(serviceId)) {
+                return totalAccounts > 0;


shouldn't this be return totalExternalAccounts > 0?

mzorz · 2018-07-30T13:33:27Z

I've tried upgrading from a fresh install of tag 10.4 to current branch release/10.5, and then instaling this branch (fix/facebook-publicize-aug-1) and the app crashes with this log:

07-30 10:31:09.046 8793-8793/org.wordpress.android I/WordPress-UTILS: WordPress.onCreate
07-30 10:31:09.058 8793-8793/org.wordpress.android E/SQLiteLog: (1) table people_team already exists
07-30 10:31:09.061 8793-8793/org.wordpress.android E/WordPress-DB: table people_team already exists (code 1): , while compiling: CREATE TABLE people_team (person_id INTEGER DEFAULT 0,local_blog_id INTEGER DEFAULT 0,user_name TEXT,display_name TEXT,avatar_url TEXT,role TEXT,PRIMARY KEY (person_id, local_blog_id));
    android.database.sqlite.SQLiteException: table people_team already exists (code 1): , while compiling: CREATE TABLE people_team (person_id INTEGER DEFAULT 0,local_blog_id INTEGER DEFAULT 0,user_name TEXT,display_name TEXT,avatar_url TEXT,role TEXT,PRIMARY KEY (person_id, local_blog_id));
        at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)
        at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:890)
        at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:501)
        at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:588)
        at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:58)
        at android.database.sqlite.SQLiteStatement.<init>(SQLiteStatement.java:31)
        at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1752)
        at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1682)
        at org.wordpress.android.datasets.PeopleTable.createTables(PeopleTable.java:33)
        at org.wordpress.android.WordPressDB.<init>(WordPressDB.java:119)
        at org.wordpress.android.WordPress.createAndVerifyWpDb(WordPress.java:434)
        at org.wordpress.android.WordPress.initWpDb(WordPress.java:424)
        at org.wordpress.android.WordPress.onCreate(WordPress.java:252)
        at org.wordpress.android.WordPressDebug.onCreate(WordPressDebug.java:14)
        at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1119)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5740)
        at android.app.ActivityThread.-wrap1(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1656)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
07-30 10:31:09.062 8793-8798/org.wordpress.android I/zygote64: Do partial code cache collection, code=59KB, data=41KB
07-30 10:31:09.062 8793-8793/org.wordpress.android E/WordPress-DB: Invalid database, sign out user and delete database
07-30 10:31:09.063 8793-8798/org.wordpress.android I/zygote64: After code cache collection, code=59KB, data=41KB
    Increasing code cache capacity to 256KB
07-30 10:31:09.131 2030-2040/? I/zygote64: Background concurrent copying GC freed 168260(6MB) AllocSpace objects, 30(1732KB) LOS objects, 50% free, 14MB/29MB, paused 97us total 114.607ms
07-30 10:31:09.191 8793-8793/org.wordpress.android I/WordPress-PEOPLE: resetting people table
07-30 10:31:09.399 8793-8793/org.wordpress.android E/SQLiteLog: (1) no such table: tbl_publicize_services
07-30 10:31:09.400 8793-8793/org.wordpress.android D/AndroidRuntime: Shutting down VM
07-30 10:31:09.401 8793-8793/org.wordpress.android E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.wordpress.android, PID: 8793
    java.lang.RuntimeException: Unable to create application org.wordpress.android.WordPressDebug: android.database.sqlite.SQLiteException: no such table: tbl_publicize_services (code 1): , while compiling: alter table tbl_publicize_services add is_external_users_only BOOLEAN;
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5743)
        at android.app.ActivityThread.-wrap1(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1656)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: android.database.sqlite.SQLiteException: no such table: tbl_publicize_services (code 1): , while compiling: alter table tbl_publicize_services add is_external_users_only BOOLEAN;
        at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)
        at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:890)
        at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:501)
        at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:588)
        at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:58)
        at android.database.sqlite.SQLiteStatement.<init>(SQLiteStatement.java:31)
        at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1752)
        at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1682)
        at org.wordpress.android.WordPressDB.<init>(WordPressDB.java:176)
        at org.wordpress.android.WordPress.initWpDb(WordPress.java:428)
        at org.wordpress.android.WordPress.onCreate(WordPress.java:252)
        at org.wordpress.android.WordPressDebug.onCreate(WordPressDebug.java:14)
        at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1119)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5740)
        at android.app.ActivityThread.-wrap1(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1656) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6494) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) 
07-30 10:31:09.405 867-2234/? W/ActivityManager:   Force finishing activity org.wordpress.android/.ui.WPLaunchActivity

mzorz · 2018-07-30T14:54:13Z

WordPress/src/main/java/org/wordpress/android/WordPressDB.java

@@ -170,6 +171,9 @@ public WordPressDB(Context ctx) {
            case 64:
                // add site icon
                mDb.execSQL(SiteSettingsModel.ADD_SITE_ICON);
+            case 65:
+                // add external users only to publicize services table
+                mDb.execSQL(PublicizeTable.ADD_EXTERNAL_USERS_ONLY);


This crashes when there is no pre-existent PublicizeTable. Apparently, it is only created when PublicizeListActivity is first visited here . We should add a check that the table exists before creating it, or force creating it before this step execution by calling PublicizeTable.createTables(mDb); right above this ALTER TABLE statement.

mzorz · 2018-07-30T15:46:59Z

As discussed over Slack, feel free to merge after the crash is taken care of @kwonye 👍

…ading from Cursor

…dpress-mobile/WordPress-Android into fix/facebook-publicize-aug-1

conditionally if it’s not empty

mzorz · 2018-07-31T01:28:40Z

Tested! LGTM

kwonye added 24 commits July 29, 2018 14:39

Hide Facebook publicize option

b7a4134

Reformat code with code style

194ee67

Adding notice and text for facebook deprecation

cdde859

Adding conditional view for facebook connections

bf10084

warning about the end of publicize on August 1

Fixing conditional on whether to hide Google plus

1a6b0e3

Adding text to link to facebook sharing changes

8ceea99

Adding new must_disconnect status for a connection

cd51f2f

Making a constant

d3733e9

Fixing formatting

9b83ef9

Adding must_disconnect case for status

9fee14f

Adding additional fields from the JSON object response

a947664

Updating table

3834d18

Creating the new model from services json

ee2be5d

Resetting the publicize services table on update

57e18e8

Removing extra semi-colon

51d9887

Revert "Updating table"

4fdea8e

This reverts commit 3834d18.

Only should hide google plus if it’s not already connected

8d15e83

Setting the name from either the display or normal name

70a0730

Add table modification in DB

e82db0b

Determine if the service is external users only

8d5c455

Counting external accounts now

edde2fb

Removing multiple external user

71bb66f

Cleaning up spaces

18d252d

Only add non-external sites if there are multiple external sites

eaa792c

kwonye added [Pri] High Sharing labels Jul 30, 2018

kwonye added this to the 10.5 ❄️ milestone Jul 30, 2018

kwonye self-assigned this Jul 30, 2018

kwonye requested review from loremattei and mzorz July 30, 2018 03:01

Fixing typo

fddb151

mzorz requested changes Jul 30, 2018

View reviewed changes

mzorz reviewed Jul 30, 2018

View reviewed changes

kwonye and others added 12 commits July 30, 2018 11:40

Allowing an external connection to change items of a connection

217f03c

Using current connection

5f0146b

Changing around the order for selection of name

d9642e1

Adding externalUserId as a parameter to pass to the server

f4bc277

Resetting the table if it exists instead of modifying it

d0b4d56

Fixing check for if there are only external accounts

69fbdc1

Cleaning up space

0737a3e

Fixing null check

4c80d6a

fixed int to bool conversion for boolean columns in Publicize when re…

5f42654

…ading from Cursor

Merge branch 'fix/facebook-publicize-aug-1' of https://github.com/wor…

2e78b52

…dpress-mobile/WordPress-Android into fix/facebook-publicize-aug-1

fixed line lengths and unused imports

81edf5d

Adding the external_user_ID parameter

b620788

conditionally if it’s not empty

mzorz merged commit f811294 into 10.5.1-rc-1 Jul 31, 2018

mzorz deleted the fix/facebook-publicize-aug-1 branch July 31, 2018 01:28

mzorz mentioned this pull request Jul 31, 2018

Publicize: Unable to connect to a Facebook page #7591

Closed

malinajirka mentioned this pull request Dec 3, 2018

Facebook publicize connection keeps failing #8715

Closed

malinajirka mentioned this pull request Aug 12, 2019

Fixes Publicize connection flow #10378

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Facebook Publicize disable selection of profiles #8115

Facebook Publicize disable selection of profiles #8115

kwonye commented Jul 30, 2018

mzorz left a comment

mzorz Jul 30, 2018

mzorz Jul 30, 2018

mzorz commented Jul 30, 2018

mzorz Jul 30, 2018

mzorz commented Jul 30, 2018

mzorz commented Jul 31, 2018

Facebook Publicize disable selection of profiles #8115

Facebook Publicize disable selection of profiles #8115

Conversation

kwonye commented Jul 30, 2018

mzorz left a comment

Choose a reason for hiding this comment

mzorz Jul 30, 2018

Choose a reason for hiding this comment

mzorz Jul 30, 2018

Choose a reason for hiding this comment

mzorz commented Jul 30, 2018

mzorz Jul 30, 2018

Choose a reason for hiding this comment

mzorz commented Jul 30, 2018

mzorz commented Jul 31, 2018