Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the max length of support name to 50 for Zendesk #8102

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Limit the max length of support name to 50 for Zendesk #8102

merged 1 commit into from
Jul 25, 2018

Conversation

oguzkocer
Copy link
Contributor

This PR adds a limit of 50 to the EditText for name in the support identity dialog. This was requested by the HEs on Slack.

To test:

  1. Uninstall and reinstall the app
  2. Go the Help page and tap on Contact Us
  3. Verify that you can't enter more than 50 characters in the Name field

Please note that this will not change the existing support names.

@aerych I requested the review from you since it's less of a code review and more of a decision one, however feel free to reassign it to anyone.

@oguzkocer oguzkocer added this to the 10.6 milestone Jul 24, 2018
@oguzkocer oguzkocer requested a review from aerych July 24, 2018 17:41
@aerych aerych self-assigned this Jul 25, 2018
@aerych
Copy link
Member

aerych commented Jul 25, 2018

Tested in the emulator and works as advertised. :shipit:
Thanks for the ping @oguzkocer. These smaller PRs are still a good exercise for me. :)

@aerych aerych merged commit d26e682 into develop Jul 25, 2018
@aerych aerych deleted the issue/limit-zendesk-name branch July 25, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerych aerych Awaiting requested review from aerych

Assignees

@aerych aerych

Labels
Support
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@oguzkocer @aerych