Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile stories block #13130

Merged
merged 273 commits into from
Nov 10, 2020
Merged

Mobile stories block #13130

merged 273 commits into from
Nov 10, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Oct 14, 2020

This PR contains all the work done for integrating the Jetpack Story block in mobile-gutenberg, and making the move from gutenberg to the story composer in the stories library integrated as well.

This is the feature branch PR.

All of the PRs have been tested.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

mzorz added 30 commits September 18, 2020 09:05
@mzorz
refactored code, introducing LoadStoryFromStoriesPrefsUseCase
df91b54
@mzorz
added path for story media not fetched locally
448dffd
@mzorz
updated stories lib hash
190b1b7
@mzorz
removed unused imports
4698ade
@mzorz
fixed merge conflict
edfe5af
@mzorz
updated dialog OK button label
143eb2e
@mzorz
Merge branch 'try/jetpack-stories-block' into try/jetpack-stories-blo…
4873009 
…ck-on-done
@mzorz
fixed merge conflict, moving call within failedLoadingOrReCreatingSto…
aacfac7 
…ry check
@mzorz
fixed lint warnings
587960f
@mzorz
Merge branch 'try/jetpack-stories-block' into try/jetpack-stories-blo…
50769fa 
…ck-on-done
@mzorz
fixed lint warnings
9ef826d
@mzorz
modified the bridge to have instances of EditorMedialListener so thes…
d7884c8 
…e know if this is an edit mode operation for each SaveResult
@mzorz
udpated stories lib hash
7f5453b
@mzorz
added all listeners to handle Story Save progress when editing a Stor…
1e41de1 
…y in Gutenberg
@mzorz
updated stories library commit hash
e532633
@mzorz
removed unused param constant key
2a74a35
@mzorz
added FrameSaveXyz status EventBus events for Story frame flattened m…
b545212 
…edia being saved
@mzorz
using StorySaveMediaListener and removed redundant interface StoryEdi…
baaad61 
…torMediaSaveListener
@mzorz
using made-up temporaryIds out of StoryIndex-FrameIndex to paint save…
a2e5aaa 
… progress states on Story blocks that are currently being processsed
@mzorz
made changes to support String mediaIds as opposed to ints, so we can…
e5adabf 
… repurpose them and also hold temporary-prefixed mediaIds while saving
@mzorz
using StoryRepositoryWrapper so it's injectable and lets StoryMediaSa…
3db3235 
…veUploadBridge in good testability state
@mzorz
updated gutenberg-mobile commit hash, also passing overall story save…
d2af486 
… progress calculation in progress event
@mzorz
added progress calculation and progress calls
5874a48
@mzorz
implemented new onStorySaveResult gutenberg bridge method
fcef7a8
@mzorz
udpated commit hash for gutenberg mobile with stories block update
edbc1e7
@mzorz
added StoryFrameMediaModelCreatedEvent event to signal Gutenberg of t…
83a977e 
…he new MediaModel id for a given Story frame, and implemented the new bridge method onMediaModelCreated
@mzorz
updated gutenberg hash, fixed media upload succesful mediaID and remo…
a2f0111 
…te URl updates in Story block
@mzorz
making sure to pass the Post's localId so it's loaded back in the bri…
e0a108d 
…dge when editing a Story block
@mzorz
avoid IOBException by making sure the list is non-emtpy
12b2563
@mzorz
only save a post in the bridge if we are not editing it - if we are e…
77d27cf 
…diting, let the Editor (Gutenberg) handle this
@mzorz mzorz mentioned this pull request Nov 4, 2020
Closed
3 tasks
@mzorz mzorz mentioned this pull request Nov 5, 2020
Merged
@mzorz mzorz marked this pull request as ready for review November 6, 2020 11:11
@mzorz mzorz mentioned this pull request Nov 9, 2020
Merged
2 tasks
@jd-alexander jd-alexander self-requested a review November 9, 2020 19:07
jd-alexander
jd-alexander approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @mzorz LGTM 🚢

@mzorz mzorz merged commit 784bc24 into develop Nov 10, 2020
@mzorz mzorz deleted the feature/jetpack-stories-block-base branch November 10, 2020 19:30
@mchowning mchowning mentioned this pull request Nov 13, 2020
Closed
@cameronvoell cameronvoell restored the feature/jetpack-stories-block-base branch November 13, 2020 21:32
cameronvoell added a commit that referenced this pull request Nov 13, 2020
@cameronvoell
Reverted PR Mobile stories block #13130
580bb75
@cameronvoell cameronvoell mentioned this pull request Nov 13, 2020
Merged
3 tasks
mzorz added a commit that referenced this pull request Nov 14, 2020
@mzorz
Merge pull request #13392 from wordpress-mobile/revert-gutenberg-mobi…
a76513c 
…le-updating-changes-post-1.41.0

Reverted PR Mobile stories block #13130
cameronvoell pushed a commit that referenced this pull request Nov 14, 2020
@mzorz @cameronvoell
Merge pull request #13130 from wordpress-mobile/feature/jetpack-stori…
e623579 
…es-block-base

Mobile stories block
@cameronvoell cameronvoell mentioned this pull request Nov 14, 2020
Merged
3 tasks
mzorz added a commit that referenced this pull request Nov 14, 2020
@mzorz
Merge pull request #13395 from wordpress-mobile/gutenberg/jetpack-sto…
cdd2198 
…ries-block-base-1.41.1

Reimplement #13130 Mobile stories block in coordination with Gutenberg release 1.41.1
@cameronvoell cameronvoell deleted the feature/jetpack-stories-block-base branch March 24, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mzorz @loremattei @jd-alexander