-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stories: prevent gif files from being added as background for new Story slides #13287
Stories: prevent gif files from being added as background for new Story slides #13287
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @mzorz Works as expected! My only suggested changes will be with the text of the dialog.
Co-authored-by: Joel Dean <[email protected]>
Co-authored-by: Joel Dean <[email protected]>
Excellent! thanks for the suggestions, I agree and just applied them 👍 - ready for another round / approval @jd-alexander 🙇 |
Since Joel already tested I'll just drive by and 👍 the dialog text with Joel's suggestions. 🎉 |
Awesome! Merging then, thank you both @jd-alexander @aforcier 🙇 |
Fixes Automattic/stories-android#592: the issue describes vido, but it's actually a gif file what the root cause of the problem was.
When a gif file is attempted to be used as a background for a Story slide, this PR shows this dialog:
(notet: open to suggestions about wording there)
To test:
First of all, make sure to add a gif file to your site's media library using tenor. Go to the media section of the app, press the + button, then select tenor as a source.
CASE A: create a story with 1 slide (gif)
CASE B: create a story using 1 gif and 1 (or more) normal image / video
PR submission checklist:
RELEASE-NOTES.txt
if necessary.