Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted PR Mobile stories block #13130 #13392

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Nov 13, 2020

Reverts #13130 and #13355

That PR updated the gutenberg-mobile reference on WPAndroid develop after our 1.41.0 gutenberg-mobile release (targeting 16.2) was already cut, so that PR is bringing in unintentional gb-mobile changes.

If we would like to still bring the changes from #13130 and #13355 to WPAndroid 16.2, we will need to create a gutenberg-mobile 1.41.1 betafix release.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 13, 2020

Warnings
⚠️ PR is missing at least one label.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@cameronvoell cameronvoell added this to the 16.2 milestone Nov 13, 2020
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested this one, checked nothing substantial was broken (posting, uploading media, etc.). We can create a Story, but can't be viewed on mobile gutenberg, which is what we can expect from reverting 👍

@mzorz mzorz merged commit a76513c into develop Nov 14, 2020
@cameronvoell cameronvoell deleted the revert-gutenberg-mobile-updating-changes-post-1.41.0 branch March 24, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants