-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Story block rendering on mobile gutenberg #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73c9f84.
…rg-mobile into try/jetpack-stories-block
…dge implementation
…toryCreatorRequestListener
This was referenced Sep 11, 2020
…atorLoad() method pass mediaFiles and clientId over the bridge
20 tasks
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…rogress component
…load handling changes
…esult bridge method
…and remoteurl on a Story frame once it finished uploading
…when editor settings has already been loading
…ock-fix-tests Stories block: hide/show based on Editor capability settings being set, only after it's been loaded
…ister-on-render Move the setupJetpackEditor() call order
6 tasks
6 tasks
etoledom
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#26721 (review)
2 tasks
mzorz
added a commit
that referenced
this pull request
Nov 14, 2020
…base-1.41.1 Re-implement #2611 Support for story block rendering on 1.41.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the jetpack Story block to be rendered on mobile-gutenberg.
Related Jetpack PR: Automattic/jetpack#17140
Related Gutenberg PR: WordPress/gutenberg#25242
Related WPAndroid PR: wordpress-mobile/WordPress-Android#12939 and wordpress-mobile/WordPress-Android#13130
Related WPIOS PR: TBD
To test:
PR submission checklist: