Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement #13130 Mobile stories block in coordination with Gutenberg release 1.41.1 #13395

Merged
merged 4 commits into from
Nov 14, 2020
Merged

Reimplement #13130 Mobile stories block in coordination with Gutenberg release 1.41.1 #13395

merged 4 commits into from
Nov 14, 2020

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Nov 14, 2020 •
edited
Loading

See #13130 for more info

Related PRs:
Gutenberg: WordPress/gutenberg#26978
Jetpack: Automattic/jetpack#17806
Gutenberg-Mobile: wordpress-mobile/gutenberg-mobile#2807
WordPress-Android: #13395

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 14, 2020 •
edited
Loading

Warnings
⚠️ PR is missing at least one label.
⚠️ PR is not assigned to a milestone.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 14, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced Nov 14, 2020
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

mzorz
mzorz approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - smoke tested and reviewed code, it's got all we had, merging back in 👍
Updated gutenberg, jetpack and gutenberg-mobile submodule hashes correspondingly as well
:shipit:

@mzorz mzorz merged commit cdd2198 into gutenberg/integrate_release_1.41.1 Nov 14, 2020
@mzorz mzorz deleted the gutenberg/jetpack-stories-block-base-1.41.1 branch November 14, 2020 05:30
@cameronvoell cameronvoell mentioned this pull request Nov 16, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronvoell @mzorz